Protocol buffers are not correctly built during installation
@jeelania10 がすでに取り組んでいます。
2026年9月1日 から。
評価
この issue はまだ評価されていません。
説明
System information
- Have I written custom code (as opposed to using a stock example script
provided in TensorFlow Model Analysis): No - OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux 6.6.57-1-lts x86_64
- TensorFlow Model Analysis installed from (source or binary): Source
- TensorFlow Model Analysis version (use command below): 7a068ec4e15224f5a1e3f23a7bcbd9bd4b030181
- Python version: 3.11.9
- Jupyter Notebook version: N/A
- Exact command to reproduce: N/A
Describe the problem
This issue is a catch-all for a number of problems with the current build system. Starting from the beginning:
- Hardcoded protobuf v3.21.9 dependency: Although the
WORKSPACEfile defines targets fromcom_google_protobufforv3.21.9, it doesn't actually use_PROTOBUF_COMMITexcept in stripping output. It should use_PROTOBUF_COMMITin both the archive name and for stripping output. - Version inconsistencies:
setup.pyrequiresprotobuf>=3.20.3forpython<3.11, which doesn't match the version grabbed by bazel. Forpython>=3.11,protobuf>=4.25.2is required, which is a full major version different and even more likely to be incompatible. - Bazel doesn't build the protocol buffers:
setup.pydoes an ad-hoc platform-dependent search forprotoc, meaning that the version ofprotobufdownloaded by bazel never gets used. If the build environment already contains any version ofprotobuf,setup.pywill happily use it, leading to generated files which are incompatible with the rest of the code. - com_google_protobuf gets clobbered by rules_rust transitive dependency: Bazel never downloads the version of
protobufthat you request in theWORKSPACEfile becauserules_rusthas a transitive dependency oncom_google_protobufthat takes precedence. Bazel silently builds the protocol buffers using a much older version ofprotobufas a result, again leading to library incompatibilities at runtime. - bazel is never invoked from
setup.py: Although there is a BUILD file for generating python code from the protobufs, bazel is never called fromsetup.py. - tensorflow_model_analysis/proto/BUILD points to the wrong protobuf dependency: Needs to point to the explicit
protobufdependency inWORKSPACE.
Even if bazel is made to build the protocol buffers, setup.py will need to be modified to grab the sources from bazel-bin/ when the wheel is being built. IMO this could be much more easily done with meson-python, which has a first-class build backend for Python already, would allow for robust version control for external tooling with fallback options as well if the host doesn't have the right version of protoc; we'd also avoid problems with transitive dependencies clobbering our actual dependencies too. If this is something folks are interested in, I'm happy to write the meson.build. Otherwise we can stick with bazel and call it by hand in setup.py.
On my system I'm unable to run tests because of this, but because bazel provides partial build isolation, whether you are affected by this or not really depends on the build environment.
cc @smokestacklightnin
- 主要言語
- Python
- スター
- 1.3k
- フォーク
- 281
- PR マージ指標
- 30日以内にマージされた PR はありません
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートなし
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
似ている issue
-
`destroy` sans terminal répond « Aborted. » au lieu de réclamer `--yes` comme `clean` et `reset`オープンbug
難易度 2/5 1〜3時間 初心者へのやさしさ 85/100
stephrobert/dsoxlab#354 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 77/100
jasonacox/pypowerwall#472 ·
メンテナーはふだん 1 日以内に返信
-
[Bug]: DoubleMLRDDData accepts a score_col that is no data column (as in its docstring example); the running variable then becomes a covariate and RDFlex fails対応中かも @vrjdev が今日担当しました。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
DoubleML/doubleml-for-py#455 ·
メンテナーはふだん 1 日以内に返信
-
[Bug]: Python mod.Box[T] annotation gets a false generic_arg edge that replaces the parameter_type one ('is' on tree-sitter nodes)対応中かも @rohit-jsfreaky が今日担当しました。 オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 88/100
Graphify-Labs/graphify#5110 · コメント 1 件 ·
メンテナーはふだん 2 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
assafelovic/gpt-researcher#2277 ·
メンテナーはふだん 10 日以内に返信