Calculator % disagrees with // on negative operands

オープン
  • 何か問題がありますか？
#602 コメント 1 件 リアクション 0 件 担当者 1 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

@YunJ-Chang がすでに取り組んでいます。

2026年11月6日 から。

  • #607 @YunJ-Chang による — オープン

評価

この issue はまだ評価されていません。

説明

Observed behavior

The task workspace calculator floors // but truncates %, so the two operators contradict each other when an operand is negative. No error is shown: the result is a wrong number. docs/task-mode.md tells learners to use this calculator rather than another app or tab during a timed attempt, so they have no other tool to catch it.

term() in web/calculator.js uses Math.floor(value / unary()) for // at line 129 and the JavaScript remainder value %= unary() at line 131. JavaScript's % takes the sign of the dividend, so it pairs with truncating division, not floored division. The identity a == (a // b) * b + a % b therefore fails whenever the operands have opposite signs. tests/browser/calculator.test.js covers only 17 // 5 and 17 % 5, so nothing exercises this case. docs/task-mode.md lists both operators without saying what they do with a negative operand.

Expected behavior

// and % should agree, so that a == (a // b) * b + a % b holds for every sign combination.
Approaches:

  1. Make % floored, so the result takes the sign of the divisor. // keeps its behavior, and the pair matches Python, whose syntax // and ** already follow.
  2. Make // truncate instead. This matches JavaScript's %, but changes an operator whose floor is deliberate and makes // differ from floor(a / b).
  3. Keep both and document the difference. This changes no code, but leaves the identity broken.

I propose approach 1, and I will send the pull request once the scope is agreed here.

Acceptance criteria:

  • a == (a // b) * b + a % b holds for every sign combination, and the table under Reproduction gives its expected column.
  • Results for non-negative operands do not change.
  • A zero divisor is still refused with the existing error.
  • tests/browser/calculator.test.js covers both operators with negative operands, and fails without the fix.
  • docs/task-mode.md states what % does with a negative operand.
Reproduction
  1. Open the calculator in the task workspace (web/task.html).
  2. Enter an expression from the table below.
  3. Press = and compare the result.
Expression Actual Expected from floored division
-7 // 3 -3 -3
-7 % 3 -1 2
(-7 // 3) * 3 + (-7 % 3) -10 -7
7 // -3 -3 -3
7 % -3 1 -2
CodeTrial version

codetrial 0.1.0 (4de45b1)

Environment

OS: Ubuntu 24.04.5 LTS on WSL2 (Windows 11)
Browser: Chrome

Sanitized evidence
Image

Captured at 4de45b1 by driving the calculator form in web/task.html with Playwright. The task section was unhidden by script, since starting a session needs Gemini and LiveKit. The form, its submit handler, and the evaluator were not changed. The files named in this report are unchanged through af66541.

Public data confirmation
  • I removed credentials, session tokens, candidate recordings, and personal interview content from this public report.
主要言語
Rust
スター
223
フォーク
148
平均マージ
1日 10時間
マージ済み PR（30日）
227

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

sysprog21/codetrial のほかの issue

sysprog21/codetrial の issue をすべて見る

似ている issue

Rust の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。