Review history drops older reports that still fit
メンテナーはふだん 1 日以内に返信
@HellHBBD がすでに取り組んでいます。
2026年11月6日 から。
評価
この issue はまだ評価されていません。
説明
Observed behavior
The browser-local review archive prematurely drops older reports, even when the 500-entry limit and the 164 KiB byte budget would allow them to be retained.
In web/history.js, boundedReviews() limits the input to the first 500 candidates before checking whether each report fits the remaining byte budget. A skipped report still consumes an input position, preventing an older report from being considered.
In a deterministic reproduction, saving three large reports into an initially full 500-entry archive leaves only 499 reports after the third save. An older report (old-497) disappears even though retaining it would keep the archive within both limits.
This affects browser-local report history. The reproduction does not demonstrate account-database report loss.
Expected behavior
A report that cannot fit within the remaining byte budget should be skipped without consuming a retained-report slot.
Older candidates should continue to be considered until either 500 reports have been retained or all available candidates have been examined.
In the reproduced scenario, the archive should retain exactly 500 reports, including old-497, totaling 160,917 bytes, below the 164 KiB (167,936 bytes) budget.
Existing newest-first ordering, UTF-8 byte accounting, code stripping, and short-history retention should remain unchanged.
Reproduction
Reproduced using the real history persistence module on upstream main at commit b2c2bc9aca5e9e70f28ff2a16e4bd0b2d5e87a2f, with Node.js v26.12.1, in-memory storage, and a mocked signed-out session.
Steps to reproduce
- Seed
codetrial_review_historywith 500 small reports,old-0throughold-499. - Seed
codetrial_historywith the newest 20 entries. - Call
saveReportHistory()three times with distinct reports containing 56,000-character summaries. - Inspect the retained review archive after each save.
Observed results
- First save: 500 retained reports, 104,904 bytes; oldest retained:
old-498. - Second save: 500 retained reports, 160,917 bytes; oldest retained:
old-497. - Third save: 499 retained reports, 160,819 bytes; oldest retained:
old-496.
After the third save, old-497 is missing. Restoring it would produce 500 reports totaling 160,917 bytes, below the 164 KiB (167,936 bytes) limit.
The failure is deterministic with this setup. The reproduction uses mocked browser storage rather than an interactive interview.
CodeTrial version
codetrial 0.1.0 (b2c2bc9)
Environment
OS: Arch Linux
Browser: Not applicable; reproduced under Node.js v26.12.1 with mocked browser storage.
Language: Not applicable.
Interview loop: Not applicable; no interview session was started.
Problem: Not applicable; browser-local review-history persistence.
REACTO or STAR step: Not applicable.
Reconnect: Not applicable.
Reproduction environment: Real web/history.js persistence module, in-memory storage, and a mocked signed-out /api/session response.
Sanitized evidence
The regression assertion fails on the unmodified upstream implementation:
AssertionError: Archive should retain 500 reports when another older report fits
499 !== 500
Relevant implementation (web/history.js, lines 462-489):
for (const row of reviews.slice(0, REVIEW_HISTORY_CAP)) {
The input is truncated before the byte-budget check. Candidates skipped for exceeding the remaining budget still occupy positions within the first 500 inputs, so older candidates are not considered.
The existing oversized-review test in tests/browser/account.test.js (lines 864-880) does not cover this interaction between a full 500-entry archive and byte-budget rejection.
Related work: #221 and PR #321 address final-code retention, not this premature review-archive eviction.
The reproduction uses synthetic report identifiers and summaries. No credentials, session tokens, recordings, or personal interview content are included.
Public data confirmation
- I removed credentials, session tokens, candidate recordings, and personal interview content from this public report.
- 主要言語
- Rust
- スター
- 223
- フォーク
- 148
- 平均マージ
- 1日 10時間
- マージ済み PR（30日）
- 227
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートあり
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
sysprog21/codetrial のほかの issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
sysprog21/codetrial#604 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
Compare code semantically across a force push in review bundles対応中かも @Alan52254 が今日担当しました。 オープン
sysprog21/codetrial#606 · 担当者 1 名 ·
メンテナーはふだん 1 日以内に返信
-
Calculator % disagrees with // on negative operands対応中かも @YunJ-Chang が今日担当しました。 オープン
sysprog21/codetrial#602 · コメント 1 件 · 担当者 1 名 ·
メンテナーはふだん 1 日以内に返信
-
Start does nothing visible in the lobby when site data is blocked対応中かも @sidney-Hung が今日担当しました。 オープン
sysprog21/codetrial#600 · コメント 1 件 · 担当者 1 名 ·
メンテナーはふだん 1 日以内に返信
-
Add a Copy results action to the coding test panel対応中かも @seallllllllll が今日担当しました。 オープン
sysprog21/codetrial#598 · コメント 1 件 · 担当者 1 名 ·
メンテナーはふだん 1 日以内に返信
sysprog21/codetrial の issue をすべて見る
似ている issue
-
multiple issues priority: low
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
storytold/pdfcraft#6469 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
bug
難易度 2/5 1〜3時間 初心者へのやさしさ 83/100
メンテナーはふだん 1 日以内に返信
-
parity priority: low ui
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
storytold/photocraft#11680 · コメント 1 件 ·
メンテナーはふだん 2 日以内に返信
-
triage/needs-triage
難易度 2/5 1〜3時間 初心者へのやさしさ 76/100
praxis-proxy/grid#564 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 66/100
ScoopInstaller/Extras#19275 ·
メンテナーはふだん 1 日以内に返信