Adopt the upstream split-backend linking once executorch#21849 lands

オープン
#1,474 コメント 0 件 リアクション 0 件 担当者 1 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

この issue はまだ評価されていません。

説明

blocked executorch

Once pytorch/executorch#21849 lands, move RNE to an ExecuTorch release that carries it and adopt the supported arrangement rather than the one we build today.

Why this needs a deliberate step

We already ship split backend .so files, but our libs are built from the PR branch and the topology we rely on is not the one the upstream AAR uses. Ours works because libRnExecutorch.so links libexecutorch.so and the backend together, so they land in one lookup group with the runtime first. The shipped v0.10.2-libs backends confirm the dependency is implicit:

libxnnpack_executorch_backend.so  NEEDED: libm, liblog, libdl, libc     # no libexecutorch
  GLOBAL DEFAULT  executorch::runtime::register_backend(...)            # its own copy

The merged version links the backend against the runtime instead, so register_backend and get_pthreadpool become UND and resolve through DT_NEEDED. That is load-order independent, and libexecutorch.so gains a matching SONAME.

What to check when we bump
  • android/CMakeLists.txt still links the backends explicitly. With DT_NEEDED in place this is no longer what makes registration work, but it is still what gets them packaged.
  • Confirm the new backends are UND for register_backend, not defining it: llvm-readelf --dyn-syms libxnnpack_executorch_backend.so | grep register_backend.
  • Confirm DT_NEEDED names libexecutorch.so and that the SONAME of our staged runtime matches, or the loader looks for a file the APK does not carry.
  • Re-check the thread pool: get_pthreadpool() must resolve to the runtime's singleton, otherwise XNNPACK runs on a second, unconfigured pool and our thread-count tuning silently does nothing.
  • Run a delegated model on device per backend. A backend registering into the wrong table fails as DelegateNotFound at execution, not at load, so a smoke test that only loads the library will not catch it.
Related
  • Upstream PR: pytorch/executorch#21849
  • Our current libs: v0.10.2-libs
主要言語
TypeScript
スター
1.8k
フォーク
101
平均マージ
2日 4時間
マージ済み PR(30日)
58

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

software-mansion/react-native-executorch のほかの issue

software-mansion/react-native-executorch の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。