Adopt the upstream split-backend linking once executorch#21849 lands

Abierto
  • ¿Algo no está bien?
#1,474 0 comentarios 0 reacciones 1 asignado Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Este issue todavía no se ha evaluado.

Descripción

blocked executorch

Once pytorch/executorch#21849 lands, move RNE to an ExecuTorch release that carries it and adopt the supported arrangement rather than the one we build today.

Why this needs a deliberate step

We already ship split backend .so files, but our libs are built from the PR branch and the topology we rely on is not the one the upstream AAR uses. Ours works because libRnExecutorch.so links libexecutorch.so and the backend together, so they land in one lookup group with the runtime first. The shipped v0.10.2-libs backends confirm the dependency is implicit:

libxnnpack_executorch_backend.so  NEEDED: libm, liblog, libdl, libc     # no libexecutorch
  GLOBAL DEFAULT  executorch::runtime::register_backend(...)            # its own copy

The merged version links the backend against the runtime instead, so register_backend and get_pthreadpool become UND and resolve through DT_NEEDED. That is load-order independent, and libexecutorch.so gains a matching SONAME.

What to check when we bump
  • android/CMakeLists.txt still links the backends explicitly. With DT_NEEDED in place this is no longer what makes registration work, but it is still what gets them packaged.
  • Confirm the new backends are UND for register_backend, not defining it: llvm-readelf --dyn-syms libxnnpack_executorch_backend.so | grep register_backend.
  • Confirm DT_NEEDED names libexecutorch.so and that the SONAME of our staged runtime matches, or the loader looks for a file the APK does not carry.
  • Re-check the thread pool: get_pthreadpool() must resolve to the runtime's singleton, otherwise XNNPACK runs on a second, unconfigured pool and our thread-count tuning silently does nothing.
  • Run a delegated model on device per backend. A backend registering into the wrong table fails as DelegateNotFound at execution, not at load, so a smoke test that only loads the library will not catch it.
Related
  • Upstream PR: pytorch/executorch#21849
  • Our current libs: v0.10.2-libs
Lenguaje dominante
TypeScript
Estrellas
1.8k
Forks
101
Merge medio
2 d 4 h
PR fusionados (30 d)
58

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de software-mansion/react-native-executorch

Todos los issues de software-mansion/react-native-executorch

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.