onEnded listeners are never removed, so every AudioBufferSourceNode stays alive (and its buffer counts as Hermes external memory) until the app runs out of memory

オープン
  • 何か問題がありますか？
#1,418 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
57/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
android, cpp, ios, javascript, react-native
領域
backend-api-design, performance

調査の方向性

Start by tracing AudioScheduledSourceNode's onEnded setter and the native AudioEventEmitter subscription it creates; the issue identifies both as the leak path. Check how subscriptions are stored and removed when the handler changes, is set to null, or ended fires. Done means replaced and cleared handlers release their subscriptions so finished nodes can be collected; the reproduction's Hermes external memory should stop growing.

索引モデルが issue の本文から書いたものです。

説明

Description

Setting node.onEnded = callback on an AudioBufferSourceNode (any AudioScheduledSourceNode) registers a listener with the native AudioEventEmitter (addAudioEventListener('ended', …)), but the returned subscription is never removed:

  • not when the ended event fires,
  • not when onEnded is set to null (the setter only sets the node's native listener id to '0'; the subscription stays in the emitter).

The emitter keeps the jsi::Function, the closure keeps the JS node, and the JS node keeps the native node. Each AudioBufferSourceNodeHostObject also calls setExternalMemoryPressure with its buffer's full size, so Hermes' external memory grows with every node that ever had onEnded set, and it never comes back down.

Impact: an app that schedules overlapping buffer segments (a seamless ambient loop: a new AudioBufferSourceNode every 16 s, each with onEnded to disconnect it) climbs steadily: Hermes js_externalBytes reached 2.9 GB after 24 minutes (Pixel 10 Pro XL) and 4.0 GB within minutes on a Pixel 8a, after which the OS killed the app with no JS error. iOS crashed the same way (Hermes out of memory at 2.2 GB).

Expected: the subscription is removed when onEnded is replaced or set to null (and ideally after ended fires for a node that can't start again), so finished nodes can be garbage-collected.

Suggested fix: keep the AudioEventSubscription returned by addAudioEventListener on the node and call remove() on it in the onEnded setter before registering a new one or when the value is null; consider removing it automatically after the ended event of a buffer source.

Workaround we use: no onEnded on segment nodes; a 1-second timer disconnects each one a second after its scheduled end.

Steps to reproduce
  1. In a development build (Hermes), run:
const ctx = new AudioContext();
const buf = ctx.createBuffer(2, ctx.sampleRate * 16, ctx.sampleRate);
setInterval(() => {
  const src = ctx.createBufferSource();
  src.buffer = buf;
  src.connect(ctx.destination);
  src.onEnded = () => { src.disconnect(); src.onEnded = null; };
  src.start(); src.stop(ctx.currentTime + 1);
}, 1000);
  1. Log HermesInternal.getInstrumentedStats().js_externalBytes every few seconds: it grows ~12 MB per second and is never collected.
  2. Remove the src.onEnded = … line and run again: js_externalBytes stays flat (the nodes are collected).
Snack or a link to a repository

https://github.com/jessenicholsfromsanfrancisco/rnaa-onended-leak-repro

React Native Audio API version

0.13.6

React Native version

0.88.1

Platforms

Android, iOS

JavaScript runtime

Hermes

Workflow

Expo Dev Client

Architecture

Fabric (New Architecture)

Build type

Release app & dev bundle

Device

Real device

Device model

iPhone 15

Acknowledgements

Yes

主要言語
C++
スター
856
フォーク
100
平均マージ
2日 1時間
マージ済み PR（30日）
34

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

software-mansion/react-native-audio-api のほかの issue

software-mansion/react-native-audio-api の issue をすべて見る

似ている issue

C++ の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。