onEnded listeners are never removed, so every AudioBufferSourceNode stays alive (and its buffer counts as Hermes external memory) until the app runs out of memory

Abierto
  • ¿Algo no está bien?
#1,418 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
57/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
android, cpp, ios, javascript, react-native
Área
backend-api-design, performance

Línea de trabajo

Start by tracing AudioScheduledSourceNode's onEnded setter and the native AudioEventEmitter subscription it creates; the issue identifies both as the leak path. Check how subscriptions are stored and removed when the handler changes, is set to null, or ended fires. Done means replaced and cleared handlers release their subscriptions so finished nodes can be collected; the reproduction's Hermes external memory should stop growing.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Description

Setting node.onEnded = callback on an AudioBufferSourceNode (any AudioScheduledSourceNode) registers a listener with the native AudioEventEmitter (addAudioEventListener('ended', …)), but the returned subscription is never removed:

  • not when the ended event fires,
  • not when onEnded is set to null (the setter only sets the node's native listener id to '0'; the subscription stays in the emitter).

The emitter keeps the jsi::Function, the closure keeps the JS node, and the JS node keeps the native node. Each AudioBufferSourceNodeHostObject also calls setExternalMemoryPressure with its buffer's full size, so Hermes' external memory grows with every node that ever had onEnded set, and it never comes back down.

Impact: an app that schedules overlapping buffer segments (a seamless ambient loop: a new AudioBufferSourceNode every 16 s, each with onEnded to disconnect it) climbs steadily: Hermes js_externalBytes reached 2.9 GB after 24 minutes (Pixel 10 Pro XL) and 4.0 GB within minutes on a Pixel 8a, after which the OS killed the app with no JS error. iOS crashed the same way (Hermes out of memory at 2.2 GB).

Expected: the subscription is removed when onEnded is replaced or set to null (and ideally after ended fires for a node that can't start again), so finished nodes can be garbage-collected.

Suggested fix: keep the AudioEventSubscription returned by addAudioEventListener on the node and call remove() on it in the onEnded setter before registering a new one or when the value is null; consider removing it automatically after the ended event of a buffer source.

Workaround we use: no onEnded on segment nodes; a 1-second timer disconnects each one a second after its scheduled end.

Steps to reproduce
  1. In a development build (Hermes), run:
const ctx = new AudioContext();
const buf = ctx.createBuffer(2, ctx.sampleRate * 16, ctx.sampleRate);
setInterval(() => {
  const src = ctx.createBufferSource();
  src.buffer = buf;
  src.connect(ctx.destination);
  src.onEnded = () => { src.disconnect(); src.onEnded = null; };
  src.start(); src.stop(ctx.currentTime + 1);
}, 1000);
  1. Log HermesInternal.getInstrumentedStats().js_externalBytes every few seconds: it grows ~12 MB per second and is never collected.
  2. Remove the src.onEnded = … line and run again: js_externalBytes stays flat (the nodes are collected).
Snack or a link to a repository

https://github.com/jessenicholsfromsanfrancisco/rnaa-onended-leak-repro

React Native Audio API version

0.13.6

React Native version

0.88.1

Platforms

Android, iOS

JavaScript runtime

Hermes

Workflow

Expo Dev Client

Architecture

Fabric (New Architecture)

Build type

Release app & dev bundle

Device

Real device

Device model

iPhone 15

Acknowledgements

Yes

Lenguaje dominante
C++
Estrellas
856
Forks
100
Merge medio
2 d 1 h
PR fusionados (30 d)
34

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de software-mansion/react-native-audio-api

Todos los issues de software-mansion/react-native-audio-api

Issues similares

Más issues de C++

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.