Hacktoberfest 2026：メンテナが10月に向けて印を付けた、オープンで初心者向けの issue。 Hacktoberfest の issue を見る

Price a request from plain values instead of the plugin request context

オープン
  • 何か問題がありますか？
#1,501 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
48/100
issue の種類
リファクタリング
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
go
領域
backend

調査の方向性

Read core/cost/settle/settle.go and core/cost/settle/avoided.go, then inspect core/plugins/inferenceparser/cost.go for the current callers. Add table tests for plain Input pricing, LiteLLM cost headers, and Comparable discount and margin checks. Done means Settle and Comparable accept plain values, their context forms wrap them, and existing cost tests pass unchanged.

索引モデルが issue の本文から書いたものです。

説明

enhancement laptop

Part of #1437 (assessment: laptop data plane on Praxis) · prep work, useful to Cortex on its own

Status: there is no shipped Cortex–Praxis integration today (the paused cmd/cortex-praxis converter is not one), and the interim path is not decided (LLM traffic to praxis-ai as an inference server, or all traffic through Praxis via #1491). Nothing here depends on that choice: each item is useful to Cortex now, and would make a possible move to Praxis easier whichever path is taken.

Problem

Pricing a request needs the whole plugin request context.

  • settle.Settle(pctx, rates) reads pctx.Host, pctx.Extensions.Inference and pctx.ResponseHeaders (LiteLLM cost headers, and Content-Type via IsEventStream); pctx.Path only in log lines.
  • Avoided reads pctx.Extensions.Custom (tool-prune's record), the request body and BodyMutated().
  • Publish writes the result back into pctx under two keys; Store keeps it in pipeline state, which litellm-budget-track reads with Load and rewrites with Amend.

Eight exported functions take *pipeline.Context: Settle, Avoided, IsEventStream, Comparable, Store, Load, Publish, Amend.

Settle is called only from inside the inference-parser plugin (cost.go:72-112), which also calls Store, Avoided and IsEventStream; litellm-budget-track calls Comparable, Load and Amend. So pricing can run only inside Cortex's Go pipeline: not from a recorded event, not in a test without building a pctx, not from another proxy.

Proposal

This issue owns settle's input. #1497 item 3 owns recording the cost-relevant headers on the event, and #1503 depends on this one.

  • Settle(in Input, rates) Settled with Input{Host, Inference, ResponseHeaders}. IsEventStream is derived from ResponseHeaders; Path is only for logging and can be passed separately or dropped.
  • Comparable(in Input) the same way.
  • Avoided keeps a pctx form for now: it needs tool-prune's record, the forwarded body and BodyMutated(), none of which belong in a pricing input.
  • Store, Load, Publish and Amend are how plugins exchange the result; they stay on pctx (their serialization is #1499 item 4).
  • Keep Settle(pctx, rates) as a thin wrapper over the new form, so existing callers and tests don't change. No behaviour change.
  • Where the wrapper lives (the inference-parser plugin, or a separate cost step) is decided in #1503.

Done when

  • Settle and Comparable have plain-value forms, and the pctx versions are wrappers over them.
  • A table test prices from plain Input values, including the LiteLLM cost-header cases and the Comparable checks on the discount and margin headers. (Gateway multipliers are on the rates side, pricing/multiplier.go, and are unaffected.)
  • Existing cost tests pass unchanged (about 43 test calls use Settle(pctx, …)).

Evidence read at main @ e455a04 (2026-10-25); not built.

主要言語
Go
スター
21
フォーク
43
平均マージ
13時間 8分
マージ済み PR（30日）
267

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

rossoctl/cortex のほかの issue

rossoctl/cortex の issue をすべて見る

似ている issue

Go の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。