Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Price a request from plain values instead of the plugin request context

Abierto
  • ¿Algo no está bien?
#1,501 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
48/100
Tipo de issue
Refactorización
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
go
Área
backend

Línea de trabajo

Read core/cost/settle/settle.go and core/cost/settle/avoided.go, then inspect core/plugins/inferenceparser/cost.go for the current callers. Add table tests for plain Input pricing, LiteLLM cost headers, and Comparable discount and margin checks. Done means Settle and Comparable accept plain values, their context forms wrap them, and existing cost tests pass unchanged.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

enhancement laptop

Part of #1437 (assessment: laptop data plane on Praxis) · prep work, useful to Cortex on its own

Status: there is no shipped Cortex–Praxis integration today (the paused cmd/cortex-praxis converter is not one), and the interim path is not decided (LLM traffic to praxis-ai as an inference server, or all traffic through Praxis via #1491). Nothing here depends on that choice: each item is useful to Cortex now, and would make a possible move to Praxis easier whichever path is taken.

Problem

Pricing a request needs the whole plugin request context.

  • settle.Settle(pctx, rates) reads pctx.Host, pctx.Extensions.Inference and pctx.ResponseHeaders (LiteLLM cost headers, and Content-Type via IsEventStream); pctx.Path only in log lines.
  • Avoided reads pctx.Extensions.Custom (tool-prune's record), the request body and BodyMutated().
  • Publish writes the result back into pctx under two keys; Store keeps it in pipeline state, which litellm-budget-track reads with Load and rewrites with Amend.

Eight exported functions take *pipeline.Context: Settle, Avoided, IsEventStream, Comparable, Store, Load, Publish, Amend.

Settle is called only from inside the inference-parser plugin (cost.go:72-112), which also calls Store, Avoided and IsEventStream; litellm-budget-track calls Comparable, Load and Amend. So pricing can run only inside Cortex's Go pipeline: not from a recorded event, not in a test without building a pctx, not from another proxy.

Proposal

This issue owns settle's input. #1497 item 3 owns recording the cost-relevant headers on the event, and #1503 depends on this one.

  • Settle(in Input, rates) Settled with Input{Host, Inference, ResponseHeaders}. IsEventStream is derived from ResponseHeaders; Path is only for logging and can be passed separately or dropped.
  • Comparable(in Input) the same way.
  • Avoided keeps a pctx form for now: it needs tool-prune's record, the forwarded body and BodyMutated(), none of which belong in a pricing input.
  • Store, Load, Publish and Amend are how plugins exchange the result; they stay on pctx (their serialization is #1499 item 4).
  • Keep Settle(pctx, rates) as a thin wrapper over the new form, so existing callers and tests don't change. No behaviour change.
  • Where the wrapper lives (the inference-parser plugin, or a separate cost step) is decided in #1503.

Done when

  • Settle and Comparable have plain-value forms, and the pctx versions are wrappers over them.
  • A table test prices from plain Input values, including the LiteLLM cost-header cases and the Comparable checks on the discount and margin headers. (Gateway multipliers are on the rates side, pricing/multiplier.go, and are unaffected.)
  • Existing cost tests pass unchanged (about 43 test calls use Settle(pctx, …)).

Evidence read at main @ e455a04 (2026-10-25); not built.

Lenguaje dominante
Go
Estrellas
21
Forks
43
Merge medio
14 h 25 min
PR fusionados (30 d)
245

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de rossoctl/cortex

Todos los issues de rossoctl/cortex

Issues similares

Más issues de Go

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.