New signups get English column names ("What", "Date") whatever their language

オープン
  • 何か問題がありますか？
#634 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
45/100
issue の種類
機能追加
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
json, typescript
領域
frontend, internationalization

調査の方向性

Read src/lib/signup-templates.ts, src/components/build-wysiwyg/InlineFieldForm.tsx, and BuildWysiwyg.tsx, then inspect the signup creation route and the existing Swedish catalog in sv.json. Implement the outlined locale-based labels, defaults, and sorting while keeping field refs unchanged. Done means Swedish defaults come from sv.json, English stays unchanged, and the listed checks pass.

索引モデルが issue の本文から書いたものです。

説明

enhancement pipeline:proposed pipeline:ux

Needs your OK: this names a new signup's default columns, and the Build tab's "Untitled" and "Option 1" defaults, in the signup's language. Swap pipeline:proposed for pipeline:ready to have it built.

What happens

Participants see these English defaults, so on a Swedish signup they'd stay English:

  • Default columns. DEFAULT_TEMPLATE (src/lib/signup-templates.ts) gives every hand-built signup columns labelled "What" and "Date".
  • Build tab defaults. The Build tab writes "Untitled" for a new field and "Option 1" for a new choice, from src/components/build-wysiwyg/InlineFieldForm.tsx.

Fix, in outline

  • Column labels. createSignup takes the template's labels from the new signup's language; the route already decides it (#627).
  • Build tab defaults. The Build tab page passes "Untitled" and "Option 1", in the signup's language, as props to the client components. They don't come from the organizer-language provider the organizer-app phase will add.
  • Sorting. Sort group labels with localeCompare(b, signupLocale) in BuildWysiwyg.tsx, with the language passed as a prop.
  • Field refs stay what and date. They're identifiers, used by tests, the MCP instructions and the evals.

Watch for

  • Help walkthroughs use "What" and "Set what" (src/help/articles/create-and-publish-a-signup.ui.ts), so English must stay the same.
  • Tests that post by ref. tests/e2e/time-format.spec.ts posts values: { what, date }.

Order

After #627 and #629: the new signup's language comes from #627, and the participant catalog and sv.json from #629.

Done when

  • A Swedish signup gets its column names and Build tab defaults from sv.json, and English is unchanged (tests).
  • pnpm lint && pnpm typecheck && pnpm knip && pnpm test and pnpm test:db pass.

Planned with the owner in https://claude.ai/code/session_01EFKmj716ZY3b3SwR8TV8Y2 and checked against the code on main at 35288fa. The full plan is private to the owner's account: https://claude.ai/artifact/VgQH6U2s2EVx3LX991fJi8 (a Claude session on that account can open it with the Artifact tool's read action). This is step 1.6 there.

主要言語
TypeScript
スター
19
フォーク
4
平均マージ
19時間 38分
マージ済み PR（30日）
197

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

richshaw/OpenSignup のほかの issue

richshaw/OpenSignup の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。