No public API (or index) for querying in-flight jobs by concurrency_key
まだ誰も着手していません。
評価
- 難易度
- 3/5
- 見積もり時間
- 1〜2日
- 初心者へのやさしさ
- 65/100
調査の方向性
Look at the ActiveJob::ConcurrencyControls module to understand how concurrency_key is generated and stored. Examine the solid_queue_jobs table schema to see the missing index. The goal is to add a public API method to query jobs by concurrency_key and add an index on that column. Check existing tests for concurrency limits to see how to test the new API.
索引モデルが issue の本文から書いたものです。
説明
Summary
SolidQueue::Job#concurrency_key (set via limits_concurrency) already encodes exactly the "is a business-level operation currently running" signal applications need — but there's no supported way to query it, and the column isn't indexed on solid_queue_jobs itself.
The app I work on Quepid has a long running jobs that do "LLM as a Judge"... I want to make sure that I don't accidentally cue up more than one Judge per specific Book. It's okay to have multiple judges work on the same Book. It's okay to have the same judge running twice, for two seperate Books. But not have the same Judge running twice for the same Book.
We wrote some janky code to look this up, and I think it would be nicer if it was part of SolidQueue.
A small part of me wondered if I have to send 1000's of query/doc pairs to evaluate to an LLM, should it be a queue, or is there a different architecture I should have picked?
Current behavior
Any job using limits_concurrency:
class RunJudgeJudyJob < ApplicationJob
limits_concurrency to: 1, key: ->(book, judge, *) { "run_judge_judy_#{book.id}_#{judge.id}" }
end
gets a concurrency_key column populated on its solid_queue_jobs row (confirmed in our own app's DB: "RunJudgeJudyJob/run_judge_judy_1_8"). That's precisely what an app needs to answer "is this book+judge combination currently being judged," or "which judges are active for this book" via a prefix match. But today we have to:
- Recompute the key format ourselves (
"#{class_name}/#{key}"), relying on an undocumented internal format (seeActiveJob::ConcurrencyControls#concurrency_key) that could change without notice. - Query it with
WHERE concurrency_key LIKE '...'against an unindexed column — a full table scan onsolid_queue_jobsas job volume grows. (solid_queue_blocked_executionsalready indexesconcurrency_key;solid_queue_jobsdoes not.) - For anything the key alone doesn't capture (e.g., extracting which argument matched a prefix), fall back to parsing the raw serialized
argumentsJSON per row anyway.
Why this belongs in SolidQueue, not application code
The key is computed and persisted entirely by SolidQueue's own ActiveJob::ConcurrencyControls extension (injected into ActiveJob::Base via SolidQueue::Engine's on_load(:active_job) hook) — there's no adapter-portable way to derive it from outside the gem. Every app using limits_concurrency for a "one active run per business entity" pattern hits this same gap and re-derives the same fragile format independently.
- 主要言語
- Ruby
- スター
- 2.5k
- フォーク
- 250
- 平均マージ
- 8時間 31分
- マージ済み PR(30日)
- 5
コントリビューションガイド
このリポジトリのコントリビューションガイドは索引されていません
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
rails/solid_queue のほかの issue
-
難易度 4/5 3〜5日 初心者へのやさしさ 45/100
rails/solid_queue#806 ·
-
難易度 3/5 1〜2日 初心者へのやさしさ 52/100
rails/solid_queue#804 · コメント 1 件 ·
-
難易度 3/5 1〜2日 初心者へのやさしさ 35/100
rails/solid_queue#802 ·
-
難易度 5/5 1週間以上 初心者へのやさしさ 35/100
rails/solid_queue#797 ·
-
難易度 4/5 3〜5日 初心者へのやさしさ 55/100
rails/solid_queue#792 · リアクション 1 件 ·
rails/solid_queue の issue をすべて見る
似ている issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 70/100
-
bug
難易度 1/5 1時間未満 初心者へのやさしさ 90/100
riscv/riscv-unified-db#2626 ·
-
Component: GLib
難易度 2/5 1〜3時間 初心者へのやさしさ 70/100
-
ds-drift
難易度 2/5 1〜3時間 初心者へのやさしさ 70/100
we-promise/sure#3693 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
simp/pupmod-simp-simp#395 ·