No public API (or index) for querying in-flight jobs by concurrency_key
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 65/100
Línea de trabajo
Look at the ActiveJob::ConcurrencyControls module to understand how concurrency_key is generated and stored. Examine the solid_queue_jobs table schema to see the missing index. The goal is to add a public API method to query jobs by concurrency_key and add an index on that column. Check existing tests for concurrency limits to see how to test the new API.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Summary
SolidQueue::Job#concurrency_key (set via limits_concurrency) already encodes exactly the "is a business-level operation currently running" signal applications need — but there's no supported way to query it, and the column isn't indexed on solid_queue_jobs itself.
The app I work on Quepid has a long running jobs that do "LLM as a Judge"... I want to make sure that I don't accidentally cue up more than one Judge per specific Book. It's okay to have multiple judges work on the same Book. It's okay to have the same judge running twice, for two seperate Books. But not have the same Judge running twice for the same Book.
We wrote some janky code to look this up, and I think it would be nicer if it was part of SolidQueue.
A small part of me wondered if I have to send 1000's of query/doc pairs to evaluate to an LLM, should it be a queue, or is there a different architecture I should have picked?
Current behavior
Any job using limits_concurrency:
class RunJudgeJudyJob < ApplicationJob
limits_concurrency to: 1, key: ->(book, judge, *) { "run_judge_judy_#{book.id}_#{judge.id}" }
end
gets a concurrency_key column populated on its solid_queue_jobs row (confirmed in our own app's DB: "RunJudgeJudyJob/run_judge_judy_1_8"). That's precisely what an app needs to answer "is this book+judge combination currently being judged," or "which judges are active for this book" via a prefix match. But today we have to:
- Recompute the key format ourselves (
"#{class_name}/#{key}"), relying on an undocumented internal format (seeActiveJob::ConcurrencyControls#concurrency_key) that could change without notice. - Query it with
WHERE concurrency_key LIKE '...'against an unindexed column — a full table scan onsolid_queue_jobsas job volume grows. (solid_queue_blocked_executionsalready indexesconcurrency_key;solid_queue_jobsdoes not.) - For anything the key alone doesn't capture (e.g., extracting which argument matched a prefix), fall back to parsing the raw serialized
argumentsJSON per row anyway.
Why this belongs in SolidQueue, not application code
The key is computed and persisted entirely by SolidQueue's own ActiveJob::ConcurrencyControls extension (injected into ActiveJob::Base via SolidQueue::Engine's on_load(:active_job) hook) — there's no adapter-portable way to derive it from outside the gem. Every app using limits_concurrency for a "one active run per business entity" pattern hits this same gap and re-derives the same fragile format independently.
- Lenguaje dominante
- Ruby
- Estrellas
- 2.5k
- Forks
- 250
- Merge medio
- 8 h 31 min
- PR fusionados (30 d)
- 5
Guía de contribución
No hay ninguna guía de contribución indexada para este repositorio
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de rails/solid_queue
-
Dificultad 4/5 3-5 días Aptitud para principiantes 45/100
rails/solid_queue#806 ·
-
limits_concurrency on_conflict: :discard looking only into running jobs and not blocked jobs Abierto
Dificultad 3/5 1-2 días Aptitud para principiantes 52/100
rails/solid_queue#804 · 1 comentario ·
-
Dificultad 3/5 1-2 días Aptitud para principiantes 35/100
rails/solid_queue#802 ·
-
Dificultad 5/5 Más de una semana Aptitud para principiantes 35/100
rails/solid_queue#797 ·
-
Dificultad 4/5 3-5 días Aptitud para principiantes 55/100
rails/solid_queue#792 · 1 reacción ·
Todos los issues de rails/solid_queue
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 65/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
-
Please Drop ruby 3.2 support Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
googleapis/google-api-ruby-client#28001 · 5 reacciones ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100