Support nested module-relative controller resolution in routes while preserving explicit controller class references
まだ誰も着手していません。
評価
調査の方向性
まず src/Router/RouteBuilder.php と src/Router/RouteDispatcher.php を通じてコントローラー解決を追跡し、次に src/Router/Route.php、リクエストのルートメタデータ、およびルート一覧表示のパスを調査します。dispatch、ルート一覧表示、メタデータにおいて、フラットなコントローラー文字列、ネストされたモジュール相対のコントローラー文字列、明示的に完全修飾されたコントローラー文字列をそれぞれ検証し、各ケースのテストを追加して、既存のフラットな動作が引き続き維持されることを確認します。
索引モデルが issue の本文から書いたものです。
説明
Summary
Enhance Quantum route controller resolution so route definitions can reference controllers in nested subnamespaces/folders within the current module, while preserving existing support for explicit fully qualified controller class references.
This should allow controller route strings such as:
PostControllerV1\PostControllerAdmin\UserController
to resolve relative to the current module’s Controllers namespace, without breaking the ability to use explicit FQCN controller class strings where intentionally supported.
Why
Current route controller resolution in Quantum is too limited for deeper controller organization.
Today, flat shorthand works for controllers that live directly under:
{Module}\Controllers\...
However, the current resolution logic uses a simple backslash check to decide whether a handler should be prefixed with the module controller namespace.
That means a nested relative controller path such as:
V1\PostController
is currently treated the same way as an explicitly qualified controller class string, even though those are different use cases.
As a result, Quantum lacks a clean way to organize controllers inside nested subnamespaces within the current module.
Goal
Allow nested controller organization inside a module while preserving both:
- current flat controller shorthand
- intentional explicit FQCN controller class references
Proposed Direction
Update route controller resolution so it can distinguish between:
Module-relative controller shorthand
Examples:
PostControllerV1\PostControllerAdmin\UserController
These should resolve relative to the current module’s Controllers namespace.
Examples:
-
PostController
resolves to:{ModuleBaseNamespace}\{CurrentModule}\Controllers\PostController
-
V1\PostController
resolves to:{ModuleBaseNamespace}\{CurrentModule}\Controllers\V1\PostController
-
Admin\UserController
resolves to:{ModuleBaseNamespace}\{CurrentModule}\Controllers\Admin\UserController
Explicit FQCN controller references
If the route handler is intentionally written as an explicit fully qualified controller class string, that behavior should remain supported.
Examples:
\Modules\Api\Controllers\V1\PostControllerModules\Api\Controllers\V1\PostController
The resolution logic should therefore no longer use “contains backslash” as the only distinction between shorthand and explicit controller references.
Instead, it should distinguish properly between:
- nested module-relative controller paths
- explicit FQCN controller class references
Why this matters
This is a prerequisite for cleaner future work such as:
- API major versioning within a single module
- better controller organization in larger modules
- route-set mounting with version-specific controller subnamespaces
without forcing:
- flat controller folders
- duplicated route definitions
- awkward controller naming workarounds
Acceptance Criteria
- flat controller shorthand continues to work
- nested controller shorthand such as
V1\PostControllerandAdmin\UserControllerresolves correctly within the current module - explicit FQCN controller class references remain supported if intentionally provided
- route listing, dispatch, and request route metadata continue to work with nested resolved controllers
- controller resolution no longer relies solely on “contains backslash” to decide whether a handler is relative or explicit
- tests verify flat controller shorthand resolution such as
PostController - tests verify nested module-relative controller shorthand such as
V1\PostController - tests verify explicit FQCN controller class references continue to resolve correctly
Notes
Relevant code:
src/Router/RouteBuilder.phpsrc/Router/RouteDispatcher.phpsrc/Router/Route.phpsrc/Http/Traits/Request/Route.phpsrc/Console/Commands/RouteListCommand.php
This ticket should be treated as a routing foundation improvement and a prerequisite for cleaner API versioning support inside a single module.
- 主要言語
- PHP
- スター
- 36
- フォーク
- 22
- PR マージ指標
- 30日以内にマージされた PR はありません
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートなし
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
quantum-php/framework のほかの issue
-
routing testing
難易度 2/5 1〜3時間 初心者へのやさしさ 76/100
quantum-php/framework#547 ·
-
view
難易度 1/5 1時間未満 初心者へのやさしさ 75/100
quantum-php/framework#542 ·
-
enhancement http
難易度 5/5 1週間以上 初心者へのやさしさ 35/100
quantum-php/framework#565 · コメント 1 件 ·
-
components view
難易度 5/5 1週間以上 初心者へのやさしさ 42/100
quantum-php/framework#551 ·
-
Add explicit @version special route token support for API major versioning within a single moduleオープンrouting
難易度 5/5 1週間以上 初心者へのやさしさ 45/100
quantum-php/framework#550 ·
quantum-php/framework の issue をすべて見る
似ている issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
invoiceninja/invoiceninja#13320 ·
メンテナーはふだん 1 日以内に返信
-
sync-en
難易度 2/5 1〜3時間 初心者へのやさしさ 76/100
メンテナーはふだん 1 日以内に返信
-
Перевод устарел
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
-
[Type] Bug
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
メンテナーはふだん 1 日以内に返信
-
bug repo:cms
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
craftcms/cms#19828 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信