RR silently not used when the game interface is already loaded (delay-load imports)

オープン
#77 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
42/100
issue の種類
バグ
明瞭さ
おおむね明確
活発さ
活発
技術スタック
cpp

調査の方向性

Start in clean/rr_f/proxy/src/hook_dll.cpp at the delay-import lookup inside if (!g_interposer) (around lines 1050-1065), then the module loop and if (delay) patch block (around lines 1105-1120). Read the test header clean/rr_f/proxy/tests/test_hook_dll.cpp to see the WG_TEST_DELAYLOAD setup. Done means the RR delay slots point into the plugin when the interface is already loaded, the host route is requested when nothing was patched, and the test passes.

索引モデルが issue の本文から書いたものです。

説明

area: ray-reconstruction bug needs-hardware-test

This was found by reading the code. It has not been reproduced.

What happens

In do_hook (clean/rr_f/proxy/src/hook_dll.cpp), the delay-import descriptor is looked up only inside if (!g_interposer) (hook_dll.cpp:1050-1053). If GetModuleHandleW already finds the interface module, delay stays null. The log then says "already loaded via import table" (hook_dll.cpp:1065), even when the exe imports it by delay-load or another module loaded it first.

The module loop patches ordinary import tables only (hook_dll.cpp:1105-1115). The only delay-IAT patch is under if (delay) (hook_dll.cpp:1116-1120). g_wait_for_host is set only when the interface is absent and not linked (hook_dll.cpp:1057), so the request for the host's route (hook_dll.cpp:1346) is not made either.

Result: the exe's delay-load slots for the interface are never patched, no host route is requested, and the game's RR calls go to the original interface. RR is silently not used. The log is misleading. There is no crash.

When it can happen

A game that delay-imports the interface, where the delay load has already fired before InitializeASI (the host loads the plugin after the game has started), or where another module (host, overlay) loaded the interface first. This timing is ordinary, not exotic. The test header (clean/rr_f/proxy/tests/test_hook_dll.cpp) covers only the "not loaded yet" branch and says the host loads the plugin after the interface is already loaded for static importers. What is lost: the RR feature on affected delay-load games, with no visible error. Medium severity.

To do

  • Always compute delay = find_delay_import(GetModuleHandleW(nullptr), kWgInterposerFile). If present, call patch_module_delay_imports whether or not the module was already loaded.
  • Keep "we loaded it ourselves" as a separate bool for the adopt_unseen_init decision (hook_dll.cpp:1088-1095). If the interface was already loaded, init may have run, so adopt.
  • If the total patched count is 0, set g_wait_for_host so the host route is still requested.
  • Fix the log line so it does not claim an import-table load when it was not.
  • Caution: patching an already-resolved delay slot is fine, the same as an IAT slot. Do not leave the adopt decision keyed on delay, or an already-initialised interface would be treated as fresh.

Test

CPU-only. In test_hook_dll, built with WG_TEST_DELAYLOAD: call one non-RR interface export (forcing the delay load), or LoadLibrary the interface before loading the plugin. Assert the RR delay slots now point into the plugin and the RR path reaches the fake runtime. A run in a real delay-load game would confirm it (see #36 for testing in a game).

主要言語
C++
スター
12
フォーク
2
平均マージ
3時間 10分
マージ済み PR(30日)
171

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

phantoslayer21/wronggpu のほかの issue

phantoslayer21/wronggpu の issue をすべて見る

似ている issue

C++ の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。