RR silently not used when the game interface is already loaded (delay-load imports)

Abierto
#77 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
42/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
cpp

Línea de trabajo

Start in clean/rr_f/proxy/src/hook_dll.cpp at the delay-import lookup inside if (!g_interposer) (around lines 1050-1065), then the module loop and if (delay) patch block (around lines 1105-1120). Read the test header clean/rr_f/proxy/tests/test_hook_dll.cpp to see the WG_TEST_DELAYLOAD setup. Done means the RR delay slots point into the plugin when the interface is already loaded, the host route is requested when nothing was patched, and the test passes.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area: ray-reconstruction bug needs-hardware-test

This was found by reading the code. It has not been reproduced.

What happens

In do_hook (clean/rr_f/proxy/src/hook_dll.cpp), the delay-import descriptor is looked up only inside if (!g_interposer) (hook_dll.cpp:1050-1053). If GetModuleHandleW already finds the interface module, delay stays null. The log then says "already loaded via import table" (hook_dll.cpp:1065), even when the exe imports it by delay-load or another module loaded it first.

The module loop patches ordinary import tables only (hook_dll.cpp:1105-1115). The only delay-IAT patch is under if (delay) (hook_dll.cpp:1116-1120). g_wait_for_host is set only when the interface is absent and not linked (hook_dll.cpp:1057), so the request for the host's route (hook_dll.cpp:1346) is not made either.

Result: the exe's delay-load slots for the interface are never patched, no host route is requested, and the game's RR calls go to the original interface. RR is silently not used. The log is misleading. There is no crash.

When it can happen

A game that delay-imports the interface, where the delay load has already fired before InitializeASI (the host loads the plugin after the game has started), or where another module (host, overlay) loaded the interface first. This timing is ordinary, not exotic. The test header (clean/rr_f/proxy/tests/test_hook_dll.cpp) covers only the "not loaded yet" branch and says the host loads the plugin after the interface is already loaded for static importers. What is lost: the RR feature on affected delay-load games, with no visible error. Medium severity.

To do

  • Always compute delay = find_delay_import(GetModuleHandleW(nullptr), kWgInterposerFile). If present, call patch_module_delay_imports whether or not the module was already loaded.
  • Keep "we loaded it ourselves" as a separate bool for the adopt_unseen_init decision (hook_dll.cpp:1088-1095). If the interface was already loaded, init may have run, so adopt.
  • If the total patched count is 0, set g_wait_for_host so the host route is still requested.
  • Fix the log line so it does not claim an import-table load when it was not.
  • Caution: patching an already-resolved delay slot is fine, the same as an IAT slot. Do not leave the adopt decision keyed on delay, or an already-initialised interface would be treated as fresh.

Test

CPU-only. In test_hook_dll, built with WG_TEST_DELAYLOAD: call one non-RR interface export (forcing the delay load), or LoadLibrary the interface before loading the plugin. Assert the RR delay slots now point into the plugin and the RR path reaches the fake runtime. A run in a real delay-load game would confirm it (see #36 for testing in a game).

Lenguaje dominante
C++
Estrellas
12
Forks
2
Merge medio
3 h 10 min
PR fusionados (30 d)
171

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de phantoslayer21/wronggpu

Todos los issues de phantoslayer21/wronggpu

Issues similares

Más issues de C++

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.