v4: a failing local API operation rolls back a transaction the caller owns, so later writes commit outside it

オープン
#19,657 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

@ghozali25 がすでに取り組んでいます。

2026年11月17日 から。

  • #19662 @ghozali25 による — オープン

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
35/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
停滞
技術スタック
node.js, postgresql, typescript
領域
backend, database

調査の方向性

Start with the catch blocks in packages/payload/src/collections/operations/create.ts, then compare the listed catch blocks in update.ts, updateByID.ts, delete.ts, deleteByID.ts, restoreVersion.ts and renameFile.ts. Trace how initTransaction signals whether an operation owns the transaction and how killTransaction uses that ownership. Reproduce with repro-2.ts; done when a failed operation leaves the caller's transaction intact and the writes behave as expected at commit.

索引モデルが issue の本文から書いたものです。

説明

area: core Bug db-postgres Payload OSS
Describe the Bug

When the caller owns a transaction (it called payload.db.beginTransaction() and passes req.transactionID), a local-API create that fails (here a validation error) rolls back the caller's transaction and deletes req.transactionID. The operation's catch calls killTransaction(args.req) unconditionally (packages/payload/src/collections/operations/create.ts), even though initTransaction returned false for it because the transaction was not its own. killTransaction's own doc comment says only the operation that started the transaction should call it.

For a caller that catches the error and carries on (e.g. a bulk import that skips invalid rows), the result is:

  • the writes made before the failure are silently rolled back;
  • req.transactionID is now undefined, so the writes made after it run outside any transaction and commit on their own;
  • the caller's commitTransaction has nothing to commit, so no error is raised anywhere.

Expected: an operation that did not start the transaction leaves it alone (the caller decides whether to roll back), or at least the caller's commit fails loudly.

update.ts, updateByID.ts, delete.ts, deleteByID.ts, restoreVersion.ts and renameFile.ts have the same unconditional killTransaction in their catch.

Link to the code that reproduces this issue

https://github.com/elghaied/payload-v4-reproductions (repro-2.ts)

Reproduction Steps
  1. pnpm install, then cp .env.example .env and point DATABASE_URL at an empty PostgreSQL database
  2. pnpm repro repro-2.ts

The script begins a transaction, creates note A, tries to create an invalid note (the error is caught), creates note C, then commits. Output:

transactionID before failing op: 7833329b-0871-4092-aa20-c1ef0a475cfa
expected failure: The following field is invalid: Title
transactionID after failing op: undefined (caller owns it; should be unchanged)
observed committed: [ 'tx-…-C' ]  expected: [A, C] together (or loud commit failure)
Which area(s) are affected?

area: core, db-postgres

Environment Info
payload: 4.0.0-beta.9
@payloadcms/db-postgres: 4.0.0-beta.9
Node.js: 24.22.1
PostgreSQL: 17.10
(local API only, no Next.js app)
主要言語
TypeScript
スター
45.8k
フォーク
4.4k
平均マージ
3日 4時間
マージ済み PR(30日)
210

環境構築

Codespaces で開く

このプロジェクトの開発コンテナを、あなたの GitHub アカウントでブラウザ上に起動します。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

payloadcms/payload のほかの issue

payloadcms/payload の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。