v4: a failing local API operation rolls back a transaction the caller owns, so later writes commit outside it

Abierto
#19,657 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@ghozali25 ya está trabajando en esto.

Desde el 17/11/2026.

  • #19662 de @ghozali25 — abierto

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
35/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Estancado
Stack tecnológico
node.js, postgresql, typescript
Área
backend, database

Línea de trabajo

Start with the catch blocks in packages/payload/src/collections/operations/create.ts, then compare the listed catch blocks in update.ts, updateByID.ts, delete.ts, deleteByID.ts, restoreVersion.ts and renameFile.ts. Trace how initTransaction signals whether an operation owns the transaction and how killTransaction uses that ownership. Reproduce with repro-2.ts; done when a failed operation leaves the caller's transaction intact and the writes behave as expected at commit.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area: core Bug db-postgres Payload OSS
Describe the Bug

When the caller owns a transaction (it called payload.db.beginTransaction() and passes req.transactionID), a local-API create that fails (here a validation error) rolls back the caller's transaction and deletes req.transactionID. The operation's catch calls killTransaction(args.req) unconditionally (packages/payload/src/collections/operations/create.ts), even though initTransaction returned false for it because the transaction was not its own. killTransaction's own doc comment says only the operation that started the transaction should call it.

For a caller that catches the error and carries on (e.g. a bulk import that skips invalid rows), the result is:

  • the writes made before the failure are silently rolled back;
  • req.transactionID is now undefined, so the writes made after it run outside any transaction and commit on their own;
  • the caller's commitTransaction has nothing to commit, so no error is raised anywhere.

Expected: an operation that did not start the transaction leaves it alone (the caller decides whether to roll back), or at least the caller's commit fails loudly.

update.ts, updateByID.ts, delete.ts, deleteByID.ts, restoreVersion.ts and renameFile.ts have the same unconditional killTransaction in their catch.

Link to the code that reproduces this issue

https://github.com/elghaied/payload-v4-reproductions (repro-2.ts)

Reproduction Steps
  1. pnpm install, then cp .env.example .env and point DATABASE_URL at an empty PostgreSQL database
  2. pnpm repro repro-2.ts

The script begins a transaction, creates note A, tries to create an invalid note (the error is caught), creates note C, then commits. Output:

transactionID before failing op: 7833329b-0871-4092-aa20-c1ef0a475cfa
expected failure: The following field is invalid: Title
transactionID after failing op: undefined (caller owns it; should be unchanged)
observed committed: [ 'tx-…-C' ]  expected: [A, C] together (or loud commit failure)
Which area(s) are affected?

area: core, db-postgres

Environment Info
payload: 4.0.0-beta.9
@payloadcms/db-postgres: 4.0.0-beta.9
Node.js: 24.22.1
PostgreSQL: 17.10
(local API only, no Next.js app)
Lenguaje dominante
TypeScript
Estrellas
45.8k
Forks
4.4k
Merge medio
3 d 4 h
PR fusionados (30 d)
210

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de payloadcms/payload

Todos los issues de payloadcms/payload

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.