v4: a failing local API operation rolls back a transaction the caller owns, so later writes commit outside it
Los mantenedores suelen responder en 1 día
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 35/100
- Tipo de issue
- Error
- Claridad
- Bien especificado
- Estado de actividad
- Estancado
- Stack tecnológico
- node.js, postgresql, typescript
Línea de trabajo
Start with the catch blocks in packages/payload/src/collections/operations/create.ts, then compare the listed catch blocks in update.ts, updateByID.ts, delete.ts, deleteByID.ts, restoreVersion.ts and renameFile.ts. Trace how initTransaction signals whether an operation owns the transaction and how killTransaction uses that ownership. Reproduce with repro-2.ts; done when a failed operation leaves the caller's transaction intact and the writes behave as expected at commit.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Describe the Bug
When the caller owns a transaction (it called payload.db.beginTransaction() and passes req.transactionID), a local-API create that fails (here a validation error) rolls back the caller's transaction and deletes req.transactionID. The operation's catch calls killTransaction(args.req) unconditionally (packages/payload/src/collections/operations/create.ts), even though initTransaction returned false for it because the transaction was not its own. killTransaction's own doc comment says only the operation that started the transaction should call it.
For a caller that catches the error and carries on (e.g. a bulk import that skips invalid rows), the result is:
- the writes made before the failure are silently rolled back;
req.transactionIDis nowundefined, so the writes made after it run outside any transaction and commit on their own;- the caller's
commitTransactionhas nothing to commit, so no error is raised anywhere.
Expected: an operation that did not start the transaction leaves it alone (the caller decides whether to roll back), or at least the caller's commit fails loudly.
update.ts, updateByID.ts, delete.ts, deleteByID.ts, restoreVersion.ts and renameFile.ts have the same unconditional killTransaction in their catch.
Link to the code that reproduces this issue
https://github.com/elghaied/payload-v4-reproductions (repro-2.ts)
Reproduction Steps
pnpm install, thencp .env.example .envand pointDATABASE_URLat an empty PostgreSQL databasepnpm repro repro-2.ts
The script begins a transaction, creates note A, tries to create an invalid note (the error is caught), creates note C, then commits. Output:
transactionID before failing op: 7833329b-0871-4092-aa20-c1ef0a475cfa
expected failure: The following field is invalid: Title
transactionID after failing op: undefined (caller owns it; should be unchanged)
observed committed: [ 'tx-…-C' ] expected: [A, C] together (or loud commit failure)
Which area(s) are affected?
area: core, db-postgres
Environment Info
payload: 4.0.0-beta.9
@payloadcms/db-postgres: 4.0.0-beta.9
Node.js: 24.22.1
PostgreSQL: 17.10
(local API only, no Next.js app)
- Lenguaje dominante
- TypeScript
- Estrellas
- 45.8k
- Forks
- 4.4k
- Merge medio
- 3 d 4 h
- PR fusionados (30 d)
- 210
Preparar el entorno
Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de payloadcms/payload
-
area: ui Bug Payload OSS
Dificultad 1/5 Menos de una hora Aptitud para principiantes 88/100
payloadcms/payload#19839 ·
Los mantenedores suelen responder en 1 día
-
Accessibility: list row and select-all checkboxes still unnamed in 3.x (#17376 fix not in 3.91)AbiertoBug Payload OSS
Dificultad 2/5 1-3 horas Aptitud para principiantes 65/100
payloadcms/payload#19837 ·
Los mantenedores suelen responder en 1 día
-
Bug Payload OSS
Dificultad 2/5 1-3 horas Aptitud para principiantes 74/100
payloadcms/payload#19835 ·
Los mantenedores suelen responder en 1 día
-
Bug Payload OSS
Dificultad 2/5 1-3 horas Aptitud para principiantes 74/100
payloadcms/payload#19833 ·
Los mantenedores suelen responder en 1 día
-
Bug Payload OSS
Dificultad 2/5 1-3 horas Aptitud para principiantes 74/100
payloadcms/payload#19832 ·
Los mantenedores suelen responder en 1 día
Todos los issues de payloadcms/payload
Issues similares
-
[BUG]: Shared links drop the configured basePath on GitHub PagesPosiblemente ocupada @anshulchikhale30-p la tomó hoy. Abiertobug
Dificultad 1/5 Menos de una hora Aptitud para principiantes 88/100
StabilityNexus/IdentityTokens-EVM-Frontend#182 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
Add: GTrekkerAbiertocheck:passed streams:add
Dificultad 1/5 Menos de una hora Aptitud para principiantes 72/100
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
Koenkk/zigbee-herdsman-converters#13900 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 85/100
Los mantenedores suelen responder en 1 día
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 88/100
jeanibarz/knowledge-base-mcp-server#1291 ·
Los mantenedores suelen responder en 1 día