The course bar selects no tab in courseware

オープン
#359 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
38/100
issue の種類
バグ
明瞭さ
おおむね明確
活発さ
活発
技術スタック
react, typescript
領域
frontend

調査の方向性

Start with CourseTabsNavigation and findActiveTab in frontend-base, then compare their URL matching with the Learning routes and the activeTabSlug behavior described in the issue. The issue leaves open how pages should identify their tab, so first resolve that design question with maintainers. Done when courseware pages, including course exit, consistently select the intended Course tab.

索引モデルが issue の本文から書いたものです。

説明

The course bar selects no tab in courseware. On Learning's master, the Course tab is selected there.

Found while porting Learning's courseware container to frontend-base (openedx/frontend-app-learning#2195, part of openedx/frontend-app-learning#1905). Related to #332.

[!NOTE]
The details below were generated by Claude (Claude Code) and reviewed before posting.

Claude Plan

How the course bar picks the selected tab

  • CourseTabsNavigation marks as active the tab that findActiveTab(resolvedTabs, location.pathname) returns.
  • findActiveTab "Returns the tab whose URL pathname is the longest prefix match against pathname, or null if none match."
  • The tabs and their URLs come from the course_metadata response. The Course tab (CoursewareTab, type courseware) links to default_course_url, which by default is get_learning_mfe_home_url(course_key, url_fragment='home'): Learning's course home, …/learning/course/<course>/home.
  • Learning's courseware pages are at …/learning/course/<course>, …/<sequence> and …/<sequence>/<unit>, with the same under …/learning/preview/course/<course>, and its course exit page is at …/learning/course/<course>/course-end (routes.tsx on Learning's frontend-base branch). None of those addresses is under a tab's URL, so findActiveTab returns null and no tab is marked.

What Learning does on master

  • Each page names its tab. The courseware container renders its tab page with activeTabSlug="courseware", and so does the course exit page.
  • isActiveTab marks the tab whose id equals that slug. The Course tab's id is its type, courseware (xmodule/tabs.py: tab_dict.get('tab_id', getattr(self, 'tab_id', self.type))), so the Course tab is selected on every courseware page. The course home passes outline, which the same function maps to the Course tab: "Users see one "Course" tab."

How it was seen

  • 2026-11-18, on the branch that ports Learning's courseware container (openedx/frontend-app-learning#2195), against Tutor dev: on a unit's page the course bar showed no tab as selected. On the course home, the same course bar shows the Course tab as selected.
  • It is the first Learning page on frontend-base whose address is under none of the tabs' URLs; until that port the courseware routes rendered a placeholder.

Questions

  • Which tab, if any, should the course bar mark on a course page whose address is under no tab's URL?
  • What tells the course bar which tab a page belongs to: the tabs' URLs, something the page's app declares, or the tab data?
主要言語
TypeScript
スター
4
フォーク
13
平均マージ
3日 5時間
マージ済み PR(30日)
4

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

openedx/frontend-base のほかの issue

openedx/frontend-base の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。