The course bar selects no tab in courseware

Abierto
#359 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
38/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
react, typescript
Área
frontend

Línea de trabajo

Start with CourseTabsNavigation and findActiveTab in frontend-base, then compare their URL matching with the Learning routes and the activeTabSlug behavior described in the issue. The issue leaves open how pages should identify their tab, so first resolve that design question with maintainers. Done when courseware pages, including course exit, consistently select the intended Course tab.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

The course bar selects no tab in courseware. On Learning's master, the Course tab is selected there.

Found while porting Learning's courseware container to frontend-base (openedx/frontend-app-learning#2195, part of openedx/frontend-app-learning#1905). Related to #332.

[!NOTE]
The details below were generated by Claude (Claude Code) and reviewed before posting.

Claude Plan

How the course bar picks the selected tab

  • CourseTabsNavigation marks as active the tab that findActiveTab(resolvedTabs, location.pathname) returns.
  • findActiveTab "Returns the tab whose URL pathname is the longest prefix match against pathname, or null if none match."
  • The tabs and their URLs come from the course_metadata response. The Course tab (CoursewareTab, type courseware) links to default_course_url, which by default is get_learning_mfe_home_url(course_key, url_fragment='home'): Learning's course home, …/learning/course/<course>/home.
  • Learning's courseware pages are at …/learning/course/<course>, …/<sequence> and …/<sequence>/<unit>, with the same under …/learning/preview/course/<course>, and its course exit page is at …/learning/course/<course>/course-end (routes.tsx on Learning's frontend-base branch). None of those addresses is under a tab's URL, so findActiveTab returns null and no tab is marked.

What Learning does on master

  • Each page names its tab. The courseware container renders its tab page with activeTabSlug="courseware", and so does the course exit page.
  • isActiveTab marks the tab whose id equals that slug. The Course tab's id is its type, courseware (xmodule/tabs.py: tab_dict.get('tab_id', getattr(self, 'tab_id', self.type))), so the Course tab is selected on every courseware page. The course home passes outline, which the same function maps to the Course tab: "Users see one "Course" tab."

How it was seen

  • 2026-11-18, on the branch that ports Learning's courseware container (openedx/frontend-app-learning#2195), against Tutor dev: on a unit's page the course bar showed no tab as selected. On the course home, the same course bar shows the Course tab as selected.
  • It is the first Learning page on frontend-base whose address is under none of the tabs' URLs; until that port the courseware routes rendered a placeholder.

Questions

  • Which tab, if any, should the course bar mark on a course page whose address is under no tab's URL?
  • What tells the course bar which tab a page belongs to: the tabs' URLs, something the page's app declares, or the tab data?
Lenguaje dominante
TypeScript
Estrellas
4
Forks
13
Merge medio
3 d 5 h
PR fusionados (30 d)
4

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de openedx/frontend-base

Todos los issues de openedx/frontend-base

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.