Header: the narrow-layout menu never shows primaryLinks (separate mobileMenuLinks slot that no app fills)

オープン
#322 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

まだ誰も着手していません。

評価

難易度
3/5
見積もり時間
半日
初心者へのやさしさ
35/100
issue の種類
バグ
明瞭さ
おおむね明確
活発さ
活発
技術スタック
react, typescript
領域
frontend

調査の方向性

The narrow menu renders the mobileMenuLinks slot in mobile/MobileNavLinks.tsx, and the wide layout renders primaryLinks in desktop/PrimaryNavLinks.tsx; the header wiring is in shell/header/app.tsx. Read how both slots are composed there and in shell/dev/devHeader/app.tsx to see which one the narrow menu is missing. Done means that primaryLinks entries appear in the mobile menu at 375 px, or that the maintainers pick the documented alternative and update the first-party apps. The choice between the two options needs a maintainer decision first.

索引モデルが issue の本文から書いたものです。

説明

bug

At narrow widths (below the header's 768 px breakpoint) the shell header drops every app's primary navigation links. The wide layout renders the org.openedx.frontend.slot.header.primaryLinks.v1 slot (desktop/PrimaryNavLinks.tsx). The narrow menu renders a different slot, org.openedx.frontend.slot.header.mobileMenuLinks.v1 (mobile/MobileNavLinks.tsx). No app fills that slot: searching the openedx org finds it only in frontend-base itself, where shell/header/app.tsx prepends the language menu. frontend-base's own dev header (shell/dev/devHeader/app.tsx) fills only primaryLinks.

Example (Tutor main, signed out, catalog home, 2026-10-16):

  • 1280 px: the header shows Explore courses → /catalog/courses, from frontend-app-catalog's headerLinkExploreCourses widget, plus Sign Up and Login.
  • 375 px: the toggle opens a menu containing only the language selector. "Explore courses" isn't anywhere in the header. The same applies to the catalog's signed-in links (Courses / Programs / Discover) and to learner-dashboard's primary links.
  • Manually confirmed on a Pixel 10 against the master sandbox.

Impact: on a phone, the main navigation each app registers is unreachable from the header. For a signed-out visitor on the landing page, the full course catalog listing can only be reached by URL.

Expected: the narrow menu shows the same primary links as the wide layout. Options: render primaryLinks inside the mobile menu (or make mobileMenuLinks include it by default), or document that apps must register their links in both slots and update the first-party apps.

Environment: frontend-base main (header code as of 2026-09-22, #316), Tutor main (overhangio/openedx-mfe:22.1.0-main). First seen 2026-09-23 with an empty menu, before #316 added the language item. Found by the Open edX end-to-end test suite (BTR TC-00061).

主要言語
TypeScript
スター
4
フォーク
13
平均マージ
3日 5時間
マージ済み PR(30日)
4

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

openedx/frontend-base のほかの issue

openedx/frontend-base の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。