Header: the narrow-layout menu never shows primaryLinks (separate mobileMenuLinks slot that no app fills)

Aperta
#322 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
Mezza giornata
Idoneità per principianti
35/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
react, typescript
Ambito
frontend

Direzione di ricerca

The narrow menu renders the mobileMenuLinks slot in mobile/MobileNavLinks.tsx, and the wide layout renders primaryLinks in desktop/PrimaryNavLinks.tsx; the header wiring is in shell/header/app.tsx. Read how both slots are composed there and in shell/dev/devHeader/app.tsx to see which one the narrow menu is missing. Done means that primaryLinks entries appear in the mobile menu at 375 px, or that the maintainers pick the documented alternative and update the first-party apps. The choice between the two options needs a maintainer decision first.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug

At narrow widths (below the header's 768 px breakpoint) the shell header drops every app's primary navigation links. The wide layout renders the org.openedx.frontend.slot.header.primaryLinks.v1 slot (desktop/PrimaryNavLinks.tsx). The narrow menu renders a different slot, org.openedx.frontend.slot.header.mobileMenuLinks.v1 (mobile/MobileNavLinks.tsx). No app fills that slot: searching the openedx org finds it only in frontend-base itself, where shell/header/app.tsx prepends the language menu. frontend-base's own dev header (shell/dev/devHeader/app.tsx) fills only primaryLinks.

Example (Tutor main, signed out, catalog home, 2026-10-16):

  • 1280 px: the header shows Explore courses → /catalog/courses, from frontend-app-catalog's headerLinkExploreCourses widget, plus Sign Up and Login.
  • 375 px: the toggle opens a menu containing only the language selector. "Explore courses" isn't anywhere in the header. The same applies to the catalog's signed-in links (Courses / Programs / Discover) and to learner-dashboard's primary links.
  • Manually confirmed on a Pixel 10 against the master sandbox.

Impact: on a phone, the main navigation each app registers is unreachable from the header. For a signed-out visitor on the landing page, the full course catalog listing can only be reached by URL.

Expected: the narrow menu shows the same primary links as the wide layout. Options: render primaryLinks inside the mobile menu (or make mobileMenuLinks include it by default), or document that apps must register their links in both slots and update the first-party apps.

Environment: frontend-base main (header code as of 2026-09-22, #316), Tutor main (overhangio/openedx-mfe:22.1.0-main). First seen 2026-09-23 with an empty menu, before #316 added the language item. Found by the Open edX end-to-end test suite (BTR TC-00061).

Lingua principale
TypeScript
Stelle
4
Fork
13
Merge medio
3g 5h
PR unite (30g)
4

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di openedx/frontend-base

Tutte le issue di openedx/frontend-base

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.