Support for hearing your own mic in game

オープン
#5,515 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 3 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
22/100
issue の種類
機能追加
明瞭さ
おおむね明確
活発さ
活発
技術スタック
cpp, lua

調査の方向性

Start from the voice broadcast handling around setPlayerVoiceBroadcastTo and the clientside voice packet flow that excludes the local player, including where onClientPlayerVoiceStart is raised. The payload names no files or tests, so first locate the Lua binding and the C++ voice subsystem that backs it. Done means a new clientside option or flag lets the local player hear their own voice with sound effects applied, without requiring packets to be sent back from the server.

索引モデルが issue の本文から書いたものです。

説明

enhancement
Is your feature request related to a problem? Please describe.

Right now, you can do

run setPlayerVoiceBroadcastTo(me, me)

And it will return true, but MTA's handling of the list removes the own player that was sending the voice packets for obvious reasons. The thing is, there is no real way clientside to hear your own voice, which seems like an oversight because that would be useful for:

  1. Being able to detect if your mic volume is too low
  2. Checking effects from setSoundEffectEnabled
  3. Making a visualizer of your own voice
  4. Being able to hear yourself in a speaker, for example
Describe the solution you'd like

Make a new function to set if your client should be able to hear himself or not. If he should, the effects to his voice should also apply (pretty sure it should work out of the box)

Describe alternatives you've considered

Make setPlayerVoiceBroadcastTo(me, me) enable clientside a flag that lets the client hear himself, unless onClientPlayerVoiceStart is cancelled. The downside of this is that, if that event is cancelled then the player won't send packets to the server.

Additional context

I understand that speex is a mess right now, and that there are/were plans to move to opus iirc. It hasn't happened, and this would be a really good QoL addition to the voice system.

There might be a way to actually do this right now with the current state of MTA? I am pretty sure there isn't but at least I haven't been able to figure it out.

Security Policy
  • I have read and understood the Security Policy and this issue is not about a cheat or security vulnerability.
主要言語
C++
スター
1.9k
フォーク
588
平均マージ
4日 9分
マージ済み PR(30日)
11

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

multitheftauto/mtasa-blue のほかの issue

multitheftauto/mtasa-blue の issue をすべて見る

似ている issue

C++ の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。