Support for hearing your own mic in game

Abierto
  • ¿Algo no está bien?
#5,515 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 3 días

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
22/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
cpp, lua
Área
audio-video-rtc, game-dev

Línea de trabajo

Start from the voice broadcast handling around setPlayerVoiceBroadcastTo and the clientside voice packet flow that excludes the local player, including where onClientPlayerVoiceStart is raised. The payload names no files or tests, so first locate the Lua binding and the C++ voice subsystem that backs it. Done means a new clientside option or flag lets the local player hear their own voice with sound effects applied, without requiring packets to be sent back from the server.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

enhancement
Is your feature request related to a problem? Please describe.

Right now, you can do

run setPlayerVoiceBroadcastTo(me, me)

And it will return true, but MTA's handling of the list removes the own player that was sending the voice packets for obvious reasons. The thing is, there is no real way clientside to hear your own voice, which seems like an oversight because that would be useful for:

  1. Being able to detect if your mic volume is too low
  2. Checking effects from setSoundEffectEnabled
  3. Making a visualizer of your own voice
  4. Being able to hear yourself in a speaker, for example
Describe the solution you'd like

Make a new function to set if your client should be able to hear himself or not. If he should, the effects to his voice should also apply (pretty sure it should work out of the box)

Describe alternatives you've considered

Make setPlayerVoiceBroadcastTo(me, me) enable clientside a flag that lets the client hear himself, unless onClientPlayerVoiceStart is cancelled. The downside of this is that, if that event is cancelled then the player won't send packets to the server.

Additional context

I understand that speex is a mess right now, and that there are/were plans to move to opus iirc. It hasn't happened, and this would be a really good QoL addition to the voice system.

There might be a way to actually do this right now with the current state of MTA? I am pretty sure there isn't but at least I haven't been able to figure it out.

Security Policy
  • I have read and understood the Security Policy and this issue is not about a cheat or security vulnerability.
Lenguaje dominante
C++
Estrellas
1.9k
Forks
588
Merge medio
4 d 9 min
PR fusionados (30 d)
11

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de multitheftauto/mtasa-blue

Todos los issues de multitheftauto/mtasa-blue

Issues similares

Más issues de C++

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.