Hacktoberfest 2026：メンテナが10月に向けて印を付けた、オープンで初心者向けの issue。 Hacktoberfest の issue を見る

A stripped stamp re-adopted on a different secret-store backend still loses what only the old backend held

オープン
  • 何か問題がありますか？
#2,672 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
5/5
見積もり時間
1週間以上
初心者へのやさしさ
35/100
issue の種類
バグ
明瞭さ
おおむね明確
活発さ
活発
技術スタック
typescript
領域
backend, security

調査の方向性

Read the linked issue #2630 and PR #2671, then trace the ledger and secret-store carry-over and purge paths described in this report. Reproduce the sequence with mixed versions and a backend switch, including a changed client registration. Done means a design prevents loss of secrets without restoring values deliberately cleared under the successor namespace.

索引モデルが issue の本文から書いたものです。

説明

bug v2

Problem

Follow-up to #2630 (PR #2671, raised in its Copilot review). #2671 carries an unstamped file's missing secrets over from the namespaces its ledger records before purging them. It reads those namespaces through the current run's secret store only. The ledger records entries per store location, so the carry-over has a gap when the backend changes in between:

  1. 2.10 saves on the keychain under namespace ns1, including a confidential DCR client's client_secret.
  2. A ≤ 2.9.x save strips the stamp.
  3. The next 2.10 run lands on a different backend (locked keychain → secrets.json, or the memory fallback). It re-adopts under ns2. The carry-over reads ns1 from that backend, finds nothing, and the stamp commits. The keychain's ns1 record is correctly kept, because only a keychain run purges keychain records.
  4. A later keychain run sees a stamped file (ns2), which never falls back, and purges ns1 from the keychain. That deletes the only copy of the secret.

Why it was not fixed in #2671

The obvious fix is to reconcile missing fields from a superseded namespace into the current, stamped namespace before purging it. That is unsafe as it stands:

  • A field missing from ns2 may be one the user deliberately cleared under ns2 (a logout, a policy downgrade). Carrying ns1's value back would resurrect it. This is why a stamped file never falls back.
  • The store holds a client_secret without the client_id it belongs to. If ns2 re-registered as a public client, a carried-over secret would be paired with the wrong client.

Expected

A design that tells "never carried, because the backend was absent" apart from "cleared since". For example, the ledger could record per location whether a namespace's contents were carried into its successor, and the purge could reconcile only namespaces that were never carried, for the entries the stamped file still indexes. Alternatively, defer the purge and accept the leak, with a warning. Needs both mixed versions and a backend switch between runs, so it is narrower than #2630.

主要言語
TypeScript
スター
11.1k
フォーク
1.6k
平均マージ
4時間 32分
マージ済み PR（30日）
136

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

modelcontextprotocol/inspector のほかの issue

modelcontextprotocol/inspector の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。