Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

A stripped stamp re-adopted on a different secret-store backend still loses what only the old backend held

Aperta
  • Qualcosa non va?
#2,672 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
35/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
typescript
Ambito
backend, security

Direzione di ricerca

Read the linked issue #2630 and PR #2671, then trace the ledger and secret-store carry-over and purge paths described in this report. Reproduce the sequence with mixed versions and a backend switch, including a changed client registration. Done means a design prevents loss of secrets without restoring values deliberately cleared under the successor namespace.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug v2

Problem

Follow-up to #2630 (PR #2671, raised in its Copilot review). #2671 carries an unstamped file's missing secrets over from the namespaces its ledger records before purging them. It reads those namespaces through the current run's secret store only. The ledger records entries per store location, so the carry-over has a gap when the backend changes in between:

  1. 2.10 saves on the keychain under namespace ns1, including a confidential DCR client's client_secret.
  2. A ≤ 2.9.x save strips the stamp.
  3. The next 2.10 run lands on a different backend (locked keychain → secrets.json, or the memory fallback). It re-adopts under ns2. The carry-over reads ns1 from that backend, finds nothing, and the stamp commits. The keychain's ns1 record is correctly kept, because only a keychain run purges keychain records.
  4. A later keychain run sees a stamped file (ns2), which never falls back, and purges ns1 from the keychain. That deletes the only copy of the secret.

Why it was not fixed in #2671

The obvious fix is to reconcile missing fields from a superseded namespace into the current, stamped namespace before purging it. That is unsafe as it stands:

  • A field missing from ns2 may be one the user deliberately cleared under ns2 (a logout, a policy downgrade). Carrying ns1's value back would resurrect it. This is why a stamped file never falls back.
  • The store holds a client_secret without the client_id it belongs to. If ns2 re-registered as a public client, a carried-over secret would be paired with the wrong client.

Expected

A design that tells "never carried, because the backend was absent" apart from "cleared since". For example, the ledger could record per location whether a namespace's contents were carried into its successor, and the purge could reconcile only namespaces that were never carried, for the entries the stamped file still indexes. Alternatively, defer the purge and accept the leak, with a warning. Needs both mixed versions and a backend switch between runs, so it is narrower than #2630.

Lingua principale
TypeScript
Stelle
11.1k
Fork
1.5k
Merge medio
4h 14m
PR unite (30g)
162

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di modelcontextprotocol/inspector

Tutte le issue di modelcontextprotocol/inspector

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.