[BUG] Custom deploy script for using certs in other containers

オープン
#636 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
1〜2日
初心者へのやさしさ
25/100
issue の種類
バグ
明瞭さ
おおむね明確
活発さ
活発
技術スタック
docker, nginx, shell

調査の方向性

The failure is in the deploy hook at /config/etc/letsencrypt/renewal-hooks/deploy/20-reload, which calls docker before the universal-docker mod has installed the binary. The container's init ordering, where mods are applied relative to the certbot renewal step, is the part to investigate. Done means the hook can run docker on the first renewal after container start. Reproducing requires a Docker environment with the mod and a forced renewal.

索引モデルが issue の本文から書いたものです。

説明

Is there an existing issue for this?
  • I have searched the existing issues
Current Behavior

I have installed swag docker with linuxserver/mods:universal-docker mod
So that I can have docker command inside swag repository, for restarting other docker services, after certificate change.

But I have found out that the mods are installed after the certificate is renewed, and after the deploy hooks have run. Therefore on swag start they would error out.

Hook will work on the next run the next month when the next renewal will start.

Expected Behavior

The mods should be installed before certificate renewal process

Steps To Reproduce
  1. Create custom deploy hook that is using docker command
  2. Change for example SUBDOMAINS so that new certificate is needed
  3. Observe as hook errors out with docker command not found
  4. Observe installation of docker mod
Environment
- OS: Debian GNU/Linux 12
- How docker service was installed: apt, docker
CPU architecture

arm64

Docker creation
services:
  swag:
    container_name: swag
    image: lscr.io/linuxserver/swag:5.9.0
    environment:
      - PUID=1000
      - PGID=1000
      - TZ=Etc/UTC
      - URL=XXX
      - VALIDATION=dns
      - SUBDOMAINS=X,XX,XXX #optional
#      - CERTPROVIDER= #optional
      - DNSPLUGIN=cloudflare #optional
#      - PROPAGATION=120 #optional
      - [email protected] #optional
      - ONLY_SUBDOMAINS=true #optional
#      - EXTRA_DOMAINS= #optional
      - STAGING=false #optional
      - DISABLE_F2B=true #optional
      - SWAG_AUTORELOAD=true #optional
#      - SWAG_AUTORELOAD_WATCHLIST= #optional

      - DOCKER_MODS=linuxserver/mods:universal-docker|linuxserver/mods:swag-dashboard
    volumes:
      - ./config:/config
      - '/var/run/docker.sock:/var/run/docker.sock'
      - ./modcache:/modcache
    dns:
     - 1.1.1.1
    networks:
      vlan:
        ipv4_address: X.X.X.X
    restart: unless-stopped

networks:
  vlan:
    external: true
Container logs
These files will be updated when the certificate renews.

NEXT STEPS:

- The certificate will need to be renewed before it expires. Certbot can automatically renew the certificate in the background, but you may need to take steps to enable that functionality. See https://certbot.org/renewal-setup for instructions.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

If you like Certbot, please consider supporting our work by:

 * Donating to ISRG / Let's Encrypt:   https://letsencrypt.org/donate

 * Donating to EFF:                    https://eff.org/donate-le

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Reloading certificates

/config/etc/letsencrypt/renewal-hooks/deploy/20-reload: line 7: docker: command not found

/config/etc/letsencrypt/renewal-hooks/deploy/20-reload: line 12: docker: command not found

New certificate generated; starting nginx

The cert does not expire within the next day. Letting the cron script handle the renewal attempts.

**** Applying the SWAG dashboard mod... ****

**** installing docker and docker compose ****

Copying over docker and docker-compose binaries

**** Adding goaccess to package install list ****

**** libmaxminddb already installed, skipping ****

**** Applied the SWAG dashboard mod ****

[pkg-install-init] **** Installing all mod packages ****

(1/1) Installing goaccess (1.10.2-r0)

Executing busybox-1.37.0-r31.trigger

OK: 219.2 MiB in 219 packages

[custom-init] No custom files found, skipping...

Auto-reload: Watching the following folders for changes to .conf files:

/config/nginx
主要言語
Dockerfile
スター
3.8k
フォーク
274
平均マージ
25分
マージ済み PR(30日)
1

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

linuxserver/docker-swag のほかの issue

linuxserver/docker-swag の issue をすべて見る

似ている issue

DevOps の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。