[BUG] Custom deploy script for using certs in other containers
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 25/100
- Tipo di issue
- Bug
- Chiarezza
- Abbastanza chiara
- Stato di attività
- Attiva
- Stack tecnologico
- docker, nginx, shell
- Ambito
- devops, infrastructure
Direzione di ricerca
The failure is in the deploy hook at /config/etc/letsencrypt/renewal-hooks/deploy/20-reload, which calls docker before the universal-docker mod has installed the binary. The container's init ordering, where mods are applied relative to the certbot renewal step, is the part to investigate. Done means the hook can run docker on the first renewal after container start. Reproducing requires a Docker environment with the mod and a forced renewal.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Is there an existing issue for this?
- I have searched the existing issues
Current Behavior
I have installed swag docker with linuxserver/mods:universal-docker mod
So that I can have docker command inside swag repository, for restarting other docker services, after certificate change.
But I have found out that the mods are installed after the certificate is renewed, and after the deploy hooks have run. Therefore on swag start they would error out.
Hook will work on the next run the next month when the next renewal will start.
Expected Behavior
The mods should be installed before certificate renewal process
Steps To Reproduce
- Create custom deploy hook that is using docker command
- Change for example SUBDOMAINS so that new certificate is needed
- Observe as hook errors out with docker command not found
- Observe installation of docker mod
Environment
- OS: Debian GNU/Linux 12
- How docker service was installed: apt, docker
CPU architecture
arm64
Docker creation
services:
swag:
container_name: swag
image: lscr.io/linuxserver/swag:5.9.0
environment:
- PUID=1000
- PGID=1000
- TZ=Etc/UTC
- URL=XXX
- VALIDATION=dns
- SUBDOMAINS=X,XX,XXX #optional
# - CERTPROVIDER= #optional
- DNSPLUGIN=cloudflare #optional
# - PROPAGATION=120 #optional
- [email protected] #optional
- ONLY_SUBDOMAINS=true #optional
# - EXTRA_DOMAINS= #optional
- STAGING=false #optional
- DISABLE_F2B=true #optional
- SWAG_AUTORELOAD=true #optional
# - SWAG_AUTORELOAD_WATCHLIST= #optional
- DOCKER_MODS=linuxserver/mods:universal-docker|linuxserver/mods:swag-dashboard
volumes:
- ./config:/config
- '/var/run/docker.sock:/var/run/docker.sock'
- ./modcache:/modcache
dns:
- 1.1.1.1
networks:
vlan:
ipv4_address: X.X.X.X
restart: unless-stopped
networks:
vlan:
external: true
Container logs
These files will be updated when the certificate renews.
NEXT STEPS:
- The certificate will need to be renewed before it expires. Certbot can automatically renew the certificate in the background, but you may need to take steps to enable that functionality. See https://certbot.org/renewal-setup for instructions.
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
If you like Certbot, please consider supporting our work by:
* Donating to ISRG / Let's Encrypt: https://letsencrypt.org/donate
* Donating to EFF: https://eff.org/donate-le
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
Reloading certificates
/config/etc/letsencrypt/renewal-hooks/deploy/20-reload: line 7: docker: command not found
/config/etc/letsencrypt/renewal-hooks/deploy/20-reload: line 12: docker: command not found
New certificate generated; starting nginx
The cert does not expire within the next day. Letting the cron script handle the renewal attempts.
**** Applying the SWAG dashboard mod... ****
**** installing docker and docker compose ****
Copying over docker and docker-compose binaries
**** Adding goaccess to package install list ****
**** libmaxminddb already installed, skipping ****
**** Applied the SWAG dashboard mod ****
[pkg-install-init] **** Installing all mod packages ****
(1/1) Installing goaccess (1.10.2-r0)
Executing busybox-1.37.0-r31.trigger
OK: 219.2 MiB in 219 packages
[custom-init] No custom files found, skipping...
Auto-reload: Watching the following folders for changes to .conf files:
/config/nginx
- Lingua principale
- Dockerfile
- Stelle
- 3.8k
- Fork
- 274
- Merge medio
- 25m
- PR unite (30g)
- 1
Preparare l'ambiente
- Include un Dockerfile o un file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di linuxserver/docker-swag
-
no-issue-activity
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
linuxserver/docker-swag#631 · 2 commenti ·
-
[BUG] Anonymous Authelia redirects can overwrite a newer login sessionForse già presa @MeiXu6693 l’ha presa 21 giorni fa. Aperta
Difficoltà 3/5 1-2 giorni Idoneità per principianti 48/100
linuxserver/docker-swag#634 · 1 commento ·
-
no-issue-activity
Difficoltà 4/5 1-2 giorni Idoneità per principianti 25/100
linuxserver/docker-swag#630 · 3 commenti ·
-
[BUG] "chmod: changing permissions of '/XXX': Bad address" error message (QNAP)Forse di nuovo libera Una pull request per questa issue è stata chiusa senza essere unita. Apertabug upstream issue work-in-progress
Difficoltà 4/5 3-5 giorni Idoneità per principianti 45/100
linuxserver/docker-swag#514 · 75 commenti ·
-
awaiting-approval
Difficoltà 4/5 3-5 giorni Idoneità per principianti 38/100
linuxserver/docker-swag#276 · 7 commenti · 6 reazioni ·
Tutte le issue di linuxserver/docker-swag
Issue simili
-
area: doc-engine area: infrastructure bug community-request
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
snapotter-hq/SnapOtter#4834 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 73/100
soroswap/token-list#125 ·
I maintainer di solito rispondono entro 1 giorno
-
enhancement roadmap: next
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
nekko-labs/nekko-agent#2998 ·
I maintainer di solito rispondono entro 1 giorno