Network applet: show only the primary connection, or everything that is connected?

オープン
#14,125 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 8 日以内に返信

まだ誰も着手していません。

評価

難易度
5/5
見積もり時間
1週間以上
初心者へのやさしさ
25/100
issue の種類
機能追加
明瞭さ
説明が足りない
活発さ
活発
技術スタック
javascript, linux
領域
desktop, frontend

調査の方向性

Read the network applet implementation and inspect the running panel behavior described in the issue. The report asks maintainers to choose between three icon designs and specify how VPN state should appear before fixes are sent; there is no implementation task or completion criterion until that decision is made.

索引モデルが issue の本文から書いたものです。

説明

The network applet's panel icon shows one connection: NetworkManager's primary connection, the one with the default route. With a wired link and Wi-Fi both up, it shows the wired icon and nothing for the Wi-Fi. A VPN changes that icon. Since #12142 (for #5527) a VPN adds a padlock to the Wi-Fi bars, but a VPN that takes over the default route (a full VPN) replaces the bars with the VPN icon, and on a wired link any VPN replaces the wired icon.

Before I send fixes:

  1. Should the panel show only the primary connection, or everything that is connected?
  2. How should a VPN show?

Three ways, in screenshots of the running applet:

The network applet in the panel for options A, B and C

  • A: as now. The padlock on the bars means a VPN is up.
  • B: as now, but a full VPN keeps the Wi-Fi bars, with the same padlock a split VPN gets, as #3671 and #6391 asked.
  • C: one icon for each kind of connection that is up: wired, Wi-Fi and VPN, so with all three up the panel shows three icons. Two or more of one kind add a count. A line over an icon marks the connection with the default route, so a full VPN looks different from a split one. The padlock on the bars means the Wi-Fi network is encrypted, as in the menu, not that a VPN is up. This is what I run.

In A and B a WireGuard full tunnel normally shows like a split VPN, because by default NetworkManager keeps the default route on the Wi-Fi or wired link. C still puts the line over the VPN.

To see the full-VPN case without Wi-Fi hardware or a VPN server

Simulated Wi-Fi, then a WireGuard tunnel to a peer that does not exist, with its default route in the main table:

sudo apt install -y hostapd wireguard-tools
sudo modprobe mac80211_hwsim radios=2
sudo nmcli device set wlan0 managed no
sleep 2
printf '%s\n' interface=wlan0 driver=nl80211 hw_mode=g channel=1 ssid=hwsim wpa=2 \
    wpa_key_mgmt=WPA-PSK rsn_pairwise=CCMP wpa_passphrase=hwsim-pass > /tmp/ap.conf
sudo hostapd -B /tmp/ap.conf
# else NM's connectivity check adds 20000 to the metric of both test links (no internet)
sudo busctl set-property org.freedesktop.NetworkManager /org/freedesktop/NetworkManager \
    org.freedesktop.NetworkManager ConnectivityCheckEnabled b false
nmcli connection add type wifi ifname wlan1 con-name hwsim ssid hwsim wifi-sec.key-mgmt wpa-psk \
    wifi-sec.psk hwsim-pass ipv4.method manual ipv4.addresses 10.99.0.2/24 \
    ipv4.gateway 10.99.0.1 ipv4.route-metric 50
until nmcli -g SSID device wifi list ifname wlan1 | grep -qx hwsim; do sleep 2; done
nmcli connection up hwsim
printf '[Interface]\nPrivateKey=%s\nAddress=10.98.0.2/32\n[Peer]\nPublicKey=%s\nAllowedIPs=0.0.0.0/0\nEndpoint=10.99.0.1:51820\n' \
    "$(wg genkey)" "$(wg genkey | wg pubkey)" > /tmp/wgfull.conf
nmcli connection import type wireguard file /tmp/wgfull.conf
nmcli connection modify wgfull wireguard.ip4-auto-default-route no ipv4.route-metric 10
nmcli connection up wgfull

On master the panel then shows the VPN icon instead of the bars.

Taken on Linux Mint 22.3 (Cinnamon 6.6.9) with master's network applet (A) and my changes to it (B, C), simulated Wi-Fi (mac80211_hwsim) and WireGuard.

(Drafted with help from Claude Opus 5.5.)

主要言語
JavaScript
スター
5.7k
フォーク
941
平均マージ
6日 18時間
マージ済み PR(30日)
12

環境構築

このプロジェクトには開発コンテナ、Dockerfile、コントリビューションガイドがありません。まず README を読み、一般的な手順ははじめてのコントリビューションガイドを参照してください。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

linuxmint/cinnamon のほかの issue

linuxmint/cinnamon の issue をすべて見る

似ている issue

JavaScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。