Network applet: show only the primary connection, or everything that is connected?

Aperta
#14,125 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 8 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
25/100
Tipo di issue
Funzionalità
Chiarezza
Da chiarire
Stato di attività
Attiva
Stack tecnologico
javascript, linux
Ambito
desktop, frontend

Direzione di ricerca

Read the network applet implementation and inspect the running panel behavior described in the issue. The report asks maintainers to choose between three icon designs and specify how VPN state should appear before fixes are sent; there is no implementation task or completion criterion until that decision is made.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

The network applet's panel icon shows one connection: NetworkManager's primary connection, the one with the default route. With a wired link and Wi-Fi both up, it shows the wired icon and nothing for the Wi-Fi. A VPN changes that icon. Since #12142 (for #5527) a VPN adds a padlock to the Wi-Fi bars, but a VPN that takes over the default route (a full VPN) replaces the bars with the VPN icon, and on a wired link any VPN replaces the wired icon.

Before I send fixes:

  1. Should the panel show only the primary connection, or everything that is connected?
  2. How should a VPN show?

Three ways, in screenshots of the running applet:

The network applet in the panel for options A, B and C

  • A: as now. The padlock on the bars means a VPN is up.
  • B: as now, but a full VPN keeps the Wi-Fi bars, with the same padlock a split VPN gets, as #3671 and #6391 asked.
  • C: one icon for each kind of connection that is up: wired, Wi-Fi and VPN, so with all three up the panel shows three icons. Two or more of one kind add a count. A line over an icon marks the connection with the default route, so a full VPN looks different from a split one. The padlock on the bars means the Wi-Fi network is encrypted, as in the menu, not that a VPN is up. This is what I run.

In A and B a WireGuard full tunnel normally shows like a split VPN, because by default NetworkManager keeps the default route on the Wi-Fi or wired link. C still puts the line over the VPN.

To see the full-VPN case without Wi-Fi hardware or a VPN server

Simulated Wi-Fi, then a WireGuard tunnel to a peer that does not exist, with its default route in the main table:

sudo apt install -y hostapd wireguard-tools
sudo modprobe mac80211_hwsim radios=2
sudo nmcli device set wlan0 managed no
sleep 2
printf '%s\n' interface=wlan0 driver=nl80211 hw_mode=g channel=1 ssid=hwsim wpa=2 \
    wpa_key_mgmt=WPA-PSK rsn_pairwise=CCMP wpa_passphrase=hwsim-pass > /tmp/ap.conf
sudo hostapd -B /tmp/ap.conf
# else NM's connectivity check adds 20000 to the metric of both test links (no internet)
sudo busctl set-property org.freedesktop.NetworkManager /org/freedesktop/NetworkManager \
    org.freedesktop.NetworkManager ConnectivityCheckEnabled b false
nmcli connection add type wifi ifname wlan1 con-name hwsim ssid hwsim wifi-sec.key-mgmt wpa-psk \
    wifi-sec.psk hwsim-pass ipv4.method manual ipv4.addresses 10.99.0.2/24 \
    ipv4.gateway 10.99.0.1 ipv4.route-metric 50
until nmcli -g SSID device wifi list ifname wlan1 | grep -qx hwsim; do sleep 2; done
nmcli connection up hwsim
printf '[Interface]\nPrivateKey=%s\nAddress=10.98.0.2/32\n[Peer]\nPublicKey=%s\nAllowedIPs=0.0.0.0/0\nEndpoint=10.99.0.1:51820\n' \
    "$(wg genkey)" "$(wg genkey | wg pubkey)" > /tmp/wgfull.conf
nmcli connection import type wireguard file /tmp/wgfull.conf
nmcli connection modify wgfull wireguard.ip4-auto-default-route no ipv4.route-metric 10
nmcli connection up wgfull

On master the panel then shows the VPN icon instead of the bars.

Taken on Linux Mint 22.3 (Cinnamon 6.6.9) with master's network applet (A) and my changes to it (B, C), simulated Wi-Fi (mac80211_hwsim) and WireGuard.

(Drafted with help from Claude Opus 5.5.)

Lingua principale
JavaScript
Stelle
5.7k
Fork
941
Merge medio
6g 18h
PR unite (30g)
12

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di linuxmint/cinnamon

Tutte le issue di linuxmint/cinnamon

Issue simili

Altre issue su JavaScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.