Hacktoberfest 2026：メンテナが10月に向けて印を付けた、オープンで初心者向けの issue。 Hacktoberfest の issue を見る

Install contributor Git hooks when dependencies are installed in a linked worktree

オープン
  • 何か問題がありますか？
#4,387 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

@lorenzozanee がすでに取り組んでいます。

2026年9月25日 から。

  • #4451 @lorenzozanee による — オープン
  • #4722 @poetryofcode による — オープン

評価

難易度
2/5
見積もり時間
1〜3時間
初心者へのやさしさ
58/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
bun, git, shell
領域
developer-experience, tooling

調査の方向性

Start with scripts.prepare in package.json and compare its Git check with the worktree behavior described in the reproduction. Read lefthook.yml for the existing worktree-related configuration, then exercise the real preparation command using an isolated installer stub. Done means ordinary clones and fresh linked worktrees invoke Lefthook, non-Git directories remain no-ops, and regression coverage leaves real hooks untouched.

索引モデルが issue の本文から書いたものです。

説明

bug difficulty/easy triage/ready

Problem

The root prepare script skips Lefthook in a Git linked worktree:

test -d .git && lefthook install || true

A linked worktree has a .git file, so the script exits successfully without invoking the installer. This matters when hooks have not already been installed in the repository's shared Git directory. An earlier installation in the primary checkout can mask the problem.

CONTRIBUTING.md promises automatic hook setup after bun install. The existing Lefthook configuration already accounts for worktree-specific Git environment variables.

Reproduction and evidence

Checked current main 86fa10ced4297bfd9f4fe67b6767afae7a07fd3c (0.8.69). Ran the exact package prepare command in three disposable fixtures with a stub lefthook executable that records its arguments. No real hooks were installed.

Fixture .git Inside Git worktree Prepare exit Installer called
Ordinary clone Directory Yes 0 lefthook install
Linked worktree of that clone File Yes 0 No
Non-Git directory Absent No 0 No

The linked worktree should invoke the same installer as an ordinary clone. A non-Git directory should remain a safe no-op.

Copyable reproduction

Run this from any directory with Git and Python 3 installed. It creates and automatically removes a disposable repository, ordinary clone, linked worktree, and non-Git control. lefthook is a logging stub placed first on the child process PATH; this never installs hooks in your actual repository.

python3 - <<'PY'
#!/usr/bin/env python3
"""Reproduce the current prepare guard without installing any real Git hooks."""
import json
import os
from pathlib import Path
import subprocess
import tempfile

with tempfile.TemporaryDirectory(prefix="hf-hook-guard-") as temporary:
    root = Path(temporary)
    seed = root / "seed"
    seed.mkdir()

    def git(*args, cwd=seed):
        return subprocess.run(
            ["git", *args], cwd=cwd, check=True, capture_output=True, text=True
        ).stdout.strip()

    git("init", "-q")
    (seed / "README").write_text("fixture\n")
    git("add", "README")
    git("-c", "user.name=Fixture", "-c", "[email protected]",
        "-c", "core.hooksPath=/dev/null", "commit", "-qm", "fixture")
    clone = root / "ordinary"
    linked = root / "linked"
    nongit = root / "non-git"
    git("clone", "-q", str(seed), str(clone))
    git("worktree", "add", "--detach", str(linked), "HEAD", cwd=clone)
    nongit.mkdir()
    stub_bin = root / "bin"
    stub_bin.mkdir()
    stub = stub_bin / "lefthook"
    stub.write_text('#!/bin/sh\nprintf "%s\\n" "$*" >> "$HF_HOOK_PROBE_LOG"\n')
    stub.chmod(0o755)
    rows = []
    for label, directory in [("ordinary", clone), ("linked", linked), ("non-git", nongit)]:
        log = root / (label + ".log")
        env = dict(os.environ, PATH=str(stub_bin) + os.pathsep + os.environ["PATH"],
                   HF_HOOK_PROBE_LOG=str(log))
        result = subprocess.run(
            ["sh", "-c", "test -d .git && lefthook install || true"],
            cwd=directory, env=env, check=True,
        )
        rows.append({"fixture": label, "prepare_exit": result.returncode,
                     "installer_calls": log.read_text().splitlines() if log.exists() else []})
    print(json.dumps(rows, indent=2))
PY

Expected current output: ordinary records ["install"]; linked and non-git record []. All three exit 0. The defect is the linked worktree's empty call list.

Scope

Make the preparation guard recognize supported Git worktrees. Preserve ordinary-clone behavior and non-Git handling. Do not change global Git configuration, replace unrelated user hooks, or rewrite the existing hook policy.

Start with package.json (scripts.prepare) and lefthook.yml. Prefer a minimal portable Git check rather than a new setup subsystem.

Acceptance criteria

  • A disposable ordinary clone invokes Lefthook during preparation.
  • A fresh linked worktree invokes it even when no hooks were installed earlier.
  • A non-Git source directory skips setup cleanly.
  • Regression coverage exercises the real preparation command with an isolated installer stub; it does not modify the developer's actual hooks.
  • Existing commit validation remains unchanged.

Triage

Suggested difficulty: easy. The change is small, but tests must avoid accidentally relying on shared hooks installed by the ordinary-clone control.

No directly overlapping open issue or PR found in the refreshed inventory. Search again before claiming. Reviewer/mentor is still being arranged; this issue is not yet a newcomer invitation.

主要言語
TypeScript
スター
54.1k
フォーク
4.9k
平均マージ
7時間 18分
マージ済み PR（30日）
784

環境構築

このプロジェクトには開発コンテナ、Dockerfile、コントリビューションガイドがありません。まず README を読み、一般的な手順ははじめてのコントリビューションガイドを参照してください。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

heygen-com/hyperframes のほかの issue

heygen-com/hyperframes の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。