storage/bigquery: google-apis-* dependency floors are lower than the wrappers actually require

オープン
#36,610 コメント 2 件 リアクション 0 件 担当者 1 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

@kalragauri がすでに取り組んでいます。

2026年10月14日 から。

評価

この issue はまだ評価されていません。

説明

api: storage priority: p3 type: bug
Versions
  • google-cloud-storage 1.62.0, google-cloud-bigquery 1.64.0
  • Ruby 3.4
Problem

The wrapper gems pass keyword arguments to their generated google-apis-* companions that older releases of those companions do not accept, but the gemspec floors were never raised to match. Bundler therefore resolves a bundle that is entirely valid by its own rules and that fails at runtime on the first call.

google-cloud-storage 1.62.0 declares:

google-apis-storage_v1 >= 0.42

but Google::Cloud::Storage::Service#list_files passes filter: to Google::Apis::StorageV1::StorageService#list_objects, and #list_buckets passes return_partial_success:. Comparing the wrapper's call sites against the generated
signatures release by release:

  • list_objects(filter:) is first accepted in google-apis-storage_v1 0.54.0
  • list_buckets(return_partial_success:) is first accepted in 0.57.0

So the real floor for google-cloud-storage 1.58.0 through 1.62.0 is google-apis-storage_v1 >= 0.57.0 — fifteen minor versions above what the gemspec asks for.

The same shape exists in BigQuery. google-cloud-bigquery 1.64.0 declares google-apis-bigquery_v2 ~> 0.71, but passes update_mode: to patch_dataset, which google-apis-bigquery_v2 first accepts in 0.88.0.

Reproduction
# Gemfile
gem "google-cloud-storage", "1.62.0"
gem "google-apis-storage_v1", "0.50.0"   # satisfies the declared >= 0.42
require "google/cloud/storage"
Google::Cloud::Storage.anonymous.bucket("any-bucket", skip_lookup: true).files
ArgumentError: unknown keyword: :filter
  google-apis-storage_v1-0.50.0/lib/google/apis/storage_v1/service.rb:2969:in 'list_objects'
  google-cloud-storage-1.62.0/lib/google/cloud/storage/service.rb:377:in 'list_files'
  google-cloud-storage-1.62.0/lib/google/cloud/storage/bucket.rb:1663:in 'files'
Why it is easy to hit

bundle update google-cloud-storage --conservative, or any resolution that holds shared
dependencies back, moves the wrapper and leaves the generated gem where it is. The result
installs cleanly, passes a test suite that stubs at the wrapper boundary, and fails the
first time an object listing runs for real.

Suggested fix
  1. Raise the declared floors to what the wrappers actually require:
    google-apis-storage_v1 >= 0.57.0 and google-apis-bigquery_v2 >= 0.88.0.
  2. Consider a release-time check that compares the keyword arguments at the wrapper's
    call sites against the signatures in the minimum supported companion release, so the
    floor cannot silently drift again the next time the generated client gains a parameter.
主要言語
Ruby
スター
1.4k
フォーク
581
平均マージ
1日 22時間
マージ済み PR(30日)
69

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

googleapis/google-cloud-ruby のほかの issue

googleapis/google-cloud-ruby の issue をすべて見る

似ている issue

Ruby の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。