storage/bigquery: google-apis-* dependency floors are lower than the wrappers actually require

Abierto
#36,610 2 comentarios 0 reacciones 1 asignado Ver en GitHub

Los mantenedores suelen responder en 1 día

@kalragauri ya está trabajando en esto.

Desde el 14/10/2026.

Evaluación

Este issue todavía no se ha evaluado.

Descripción

api: storage priority: p3 type: bug
Versions
  • google-cloud-storage 1.62.0, google-cloud-bigquery 1.64.0
  • Ruby 3.4
Problem

The wrapper gems pass keyword arguments to their generated google-apis-* companions that older releases of those companions do not accept, but the gemspec floors were never raised to match. Bundler therefore resolves a bundle that is entirely valid by its own rules and that fails at runtime on the first call.

google-cloud-storage 1.62.0 declares:

google-apis-storage_v1 >= 0.42

but Google::Cloud::Storage::Service#list_files passes filter: to Google::Apis::StorageV1::StorageService#list_objects, and #list_buckets passes return_partial_success:. Comparing the wrapper's call sites against the generated
signatures release by release:

  • list_objects(filter:) is first accepted in google-apis-storage_v1 0.54.0
  • list_buckets(return_partial_success:) is first accepted in 0.57.0

So the real floor for google-cloud-storage 1.58.0 through 1.62.0 is google-apis-storage_v1 >= 0.57.0 — fifteen minor versions above what the gemspec asks for.

The same shape exists in BigQuery. google-cloud-bigquery 1.64.0 declares google-apis-bigquery_v2 ~> 0.71, but passes update_mode: to patch_dataset, which google-apis-bigquery_v2 first accepts in 0.88.0.

Reproduction
# Gemfile
gem "google-cloud-storage", "1.62.0"
gem "google-apis-storage_v1", "0.50.0"   # satisfies the declared >= 0.42
require "google/cloud/storage"
Google::Cloud::Storage.anonymous.bucket("any-bucket", skip_lookup: true).files
ArgumentError: unknown keyword: :filter
  google-apis-storage_v1-0.50.0/lib/google/apis/storage_v1/service.rb:2969:in 'list_objects'
  google-cloud-storage-1.62.0/lib/google/cloud/storage/service.rb:377:in 'list_files'
  google-cloud-storage-1.62.0/lib/google/cloud/storage/bucket.rb:1663:in 'files'
Why it is easy to hit

bundle update google-cloud-storage --conservative, or any resolution that holds shared
dependencies back, moves the wrapper and leaves the generated gem where it is. The result
installs cleanly, passes a test suite that stubs at the wrapper boundary, and fails the
first time an object listing runs for real.

Suggested fix
  1. Raise the declared floors to what the wrappers actually require:
    google-apis-storage_v1 >= 0.57.0 and google-apis-bigquery_v2 >= 0.88.0.
  2. Consider a release-time check that compares the keyword arguments at the wrapper's
    call sites against the signatures in the minimum supported companion release, so the
    floor cannot silently drift again the next time the generated client gains a parameter.
Lenguaje dominante
Ruby
Estrellas
1.4k
Forks
581
Merge medio
1 d 22 h
PR fusionados (30 d)
69

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de googleapis/google-cloud-ruby

Todos los issues de googleapis/google-cloud-ruby

Issues similares

Más issues de Ruby

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.