Hacktoberfest 2026：メンテナが10月に向けて印を付けた、オープンで初心者向けの issue。 Hacktoberfest の issue を見る

Fixed-in-version regression check discards every event in the batch, including the regressing event

オープン
  • 何か問題がありますか？
#2,700 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
74/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
csharp
領域
backend, testing

調査の方向性

Read src/Exceptionless.Core/Pipeline/030_CheckForRegressionAction.cs around lines 50–80 and the existing EnsureVersionedRegressionAsync test. Trace how version groups are ordered and how discarded contexts skip later pipeline actions; then add a pipeline test with the older event dated before the newer one. Done means only the older-version event is discarded and the newer event is saved as the regression with notifications queued.

索引モデルが issue の本文から書いたものです。

説明

bug

When a stack is marked fixed in a version and a batch has an event older than that version, CheckForRegressionAction discards every event for the stack in that batch, not just the older version's events. If the batch also contains a newer-version event, the stack is still marked regressed, but the event that caused the regression is discarded, so it isn't saved and no regression notification or webhook is sent.

Where

030_CheckForRegressionAction.cs#L50-L80

foreach (var versionGroup in versions)
{
    var version = ...;
    if (version < fixedInVersion)
    {
        foreach (var ctx in stackGroup.Where(s => s.Organization.HasPremiumFeatures)) // should be versionGroup
        {
            ctx.IsDiscarded = true;
            ctx.IsCancelled = true;
        }
        continue;
    }
    regressedVersion = version;
    regressedContext = versionGroup.First();
    break;
}

What happens

For a paid organization, with a stack fixed in 1.0.1 and one batch that contains 1.0.0 (earlier date) and 1.0.2 (later date) events for that stack:

  1. Groups are ordered by event date, so the 1.0.0 group is checked first. The inner loop iterates stackGroup, so both events are marked discarded and cancelled.
  2. The loop continues to 1.0.2, which sets regressedContext. The stack is saved as Regressed and that context gets IsRegression = true.
  3. The context is already cancelled, so later pipeline actions skip it (PipelineBase.cs#L62). The event isn't stored, and QueueNotificationAction never queues the regression notification or the StackRegression webhook.

The result also depends on order. If the newer event is earlier in the batch, the loop breaks on it before reaching the older group, so the older-version events are kept rather than discarded.

The existing test EnsureVersionedRegressionAsync puts the regressing event first by date, so it doesn't cover this case.

Expected

Only events older than the fixed version are discarded. A newer-version event in the same batch is saved, flagged as the regression, and triggers notifications.

Suggested fix

Iterate versionGroup instead of stackGroup when discarding. Evaluate every version group rather than breaking on the first regression, so older-version events later in the batch are discarded consistently. Add a pipeline test with an older-version event dated before a newer-version event.

主要言語
C#
スター
2.5k
フォーク
508
平均マージ
2日 17時間
マージ済み PR（30日）
40

環境構築

Codespaces で開く

このプロジェクトの開発コンテナを、あなたの GitHub アカウントでブラウザ上に起動します。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

exceptionless/Exceptionless のほかの issue

exceptionless/Exceptionless の issue をすべて見る

似ている issue

C# の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。