Browser uses this computer's internet only after the owner grants it, as a revocable capability

オープン
#559 コメント 7 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
5/5
見積もり時間
1週間以上
初心者へのやさしさ
20/100
issue の種類
機能追加
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
rust

調査の方向性

Read the referenced Runtime routes in gateway_browser.rs and gateway_provider_proxy.rs, then trace the setup in scripts/browser-source-home-config.mjs and the approval work in #177 and #178. The direction calls for a Runtime-held, revocable grant checked by Gateway and exit-provider for local and remote Exits. Done includes approval, immediate revocation, migration behavior, release notes and SECURITY.md updates, plus design review by Irzhy.

索引モデルが issue の本文から書いたものです。

説明

Problem

Browser reaches the internet through this computer's connection without the owner ever granting it (Anders, 7 Nov: "the browser should be using capability tokens to get internet access").

Containment holds: pages never get a network device or raw sockets. The Mac VM has no network device (elastos-vz/src/bin/browser-vz-engine-supervisor.rs:970), the Linux tap forwards nothing (scripts/browser-vm-linux-network.py), and every connection goes Gateway (gateway_browser_stream.rs) to exit-provider to browser-local-exit, which dials from the host.

Consent does not:

  • Setup writes the local Exit with allowed_hosts: ["*"], ports 80 and 443, plus the Runtime's own local ports 8090 and 61180 (scripts/browser-source-home-config.mjs:510-536). Same in 2.0.0.
  • The Runtime's check is the signed launch token's actor being browser (require_runtime_wallet_authority(..., &[BROWSER_CAPSULE_ID]), gateway_browser.rs:428, 620, 711; gateway_provider_proxy.rs allowlist). The manifest capability elastos://browser/exit is not checked by any Runtime route.
  • Home can mint any app's launch token (SECURITY.md, "Home can currently obtain every app's capability").
  • Browser Settings, Exit node, offers This device or a remote Exit; there is no Off.
  • The release notes never say Browser uses this computer's internet connection.

This breaks PRINCIPLES.md ("capabilities must be explicit ... narrow, auditable, and revocable"; Exit "must stay behind explicit Runtime policy").

Direction

The Runtime holds Browser's internet grant as a capability: issued only after the owner approves it once on the Runtime-owned approval surface (#178) with the passkey, bound to Browser on this Home (principal, session, instance) and never readable by Home or the app (#177). Gateway and exit-provider check that grant on every connection instead of the actor name, for the local and remote Exits alike. Without it, Browser shows one page asking for permission. Revoking in System refuses new connections at once and closes open ones within 2 seconds (#173 Browser authority contribution).

Done means

  • A fresh Home's Browser opens no connection until the owner approves; the approval names this computer's connection.
  • Revoke in System stops new and open connections within 2 s; restart and token expiry keep it revoked.
  • A Home-minted Browser launch token without the grant is refused for local and remote Exits.
  • Updating a Home that used Browser before asks once, and does not keep the old implicit grant.
  • Release notes and SECURITY.md say what Browser can reach.
  • Design reviewed by Irzhy before code.

Part of #173; depends on #177 and #178.

主要言語
Rust
スター
6
フォーク
2
平均マージ
1日 3時間
マージ済み PR(30日)
42

環境構築

このプロジェクトには開発コンテナ、Dockerfile、コントリビューションガイドがありません。まず README を読み、一般的な手順ははじめてのコントリビューションガイドを参照してください。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

elastos/elastos-runtime のほかの issue

elastos/elastos-runtime の issue をすべて見る

似ている issue

Rust の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。