Browser uses this computer's internet only after the owner grants it, as a revocable capability

Ouverte
  • Quelque chose ne va pas ?
#559 7 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
5/5
Temps estimé
Plus d'une semaine
Accessibilité débutants
20/100
Type d'issue
Fonctionnalité
Clarté
Clairement spécifiée
Activité
Active
Stack technique
rust
Domaine
authentication, backend-api-design, security

Piste de recherche

Read the referenced Runtime routes in gateway_browser.rs and gateway_provider_proxy.rs, then trace the setup in scripts/browser-source-home-config.mjs and the approval work in #177 and #178. The direction calls for a Runtime-held, revocable grant checked by Gateway and exit-provider for local and remote Exits. Done includes approval, immediate revocation, migration behavior, release notes and SECURITY.md updates, plus design review by Irzhy.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Problem

Browser reaches the internet through this computer's connection without the owner ever granting it (Anders, 7 Nov: "the browser should be using capability tokens to get internet access").

Containment holds: pages never get a network device or raw sockets. The Mac VM has no network device (elastos-vz/src/bin/browser-vz-engine-supervisor.rs:970), the Linux tap forwards nothing (scripts/browser-vm-linux-network.py), and every connection goes Gateway (gateway_browser_stream.rs) to exit-provider to browser-local-exit, which dials from the host.

Consent does not:

  • Setup writes the local Exit with allowed_hosts: ["*"], ports 80 and 443, plus the Runtime's own local ports 8090 and 61180 (scripts/browser-source-home-config.mjs:510-536). Same in 2.0.0.
  • The Runtime's check is the signed launch token's actor being browser (require_runtime_wallet_authority(..., &[BROWSER_CAPSULE_ID]), gateway_browser.rs:428, 620, 711; gateway_provider_proxy.rs allowlist). The manifest capability elastos://browser/exit is not checked by any Runtime route.
  • Home can mint any app's launch token (SECURITY.md, "Home can currently obtain every app's capability").
  • Browser Settings, Exit node, offers This device or a remote Exit; there is no Off.
  • The release notes never say Browser uses this computer's internet connection.

This breaks PRINCIPLES.md ("capabilities must be explicit ... narrow, auditable, and revocable"; Exit "must stay behind explicit Runtime policy").

Direction

The Runtime holds Browser's internet grant as a capability: issued only after the owner approves it once on the Runtime-owned approval surface (#178) with the passkey, bound to Browser on this Home (principal, session, instance) and never readable by Home or the app (#177). Gateway and exit-provider check that grant on every connection instead of the actor name, for the local and remote Exits alike. Without it, Browser shows one page asking for permission. Revoking in System refuses new connections at once and closes open ones within 2 seconds (#173 Browser authority contribution).

Done means

  • A fresh Home's Browser opens no connection until the owner approves; the approval names this computer's connection.
  • Revoke in System stops new and open connections within 2 s; restart and token expiry keep it revoked.
  • A Home-minted Browser launch token without the grant is refused for local and remote Exits.
  • Updating a Home that used Browser before asks once, and does not keep the old implicit grant.
  • Release notes and SECURITY.md say what Browser can reach.
  • Design reviewed by Irzhy before code.

Part of #173; depends on #177 and #178.

Langage dominant
Rust
Étoiles
6
Forks
2
Merge moyen
1 j 3 h
PR mergées (30 j)
42

Préparer son environnement

Ce projet ne fournit ni conteneur de développement, ni Dockerfile, ni guide de contribution : l'installation est à votre charge. Commencez par son README, et consultez notre guide de la première contribution pour les étapes générales.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de elastos/elastos-runtime

Toutes les issues de elastos/elastos-runtime

Issues similaires

Plus d'issues Rust

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.