ContainerEventManager cannot remove a service listener by its resolved object
評価
- 難易度
- 3/5
- 見積もり時間
- 1〜2日
- 初心者へのやさしさ
- 35/100
調査の方向性
Start with ContainerEventManager and the service registration, resolution, and removal paths described in the issue. Run the supplied reproduce.php script to confirm that removal leaves a listener registered and one dispatch calls it twice after re-adding. Done means removal by the resolved object leaves no listener, and re-adding it produces exactly one callback; linked pull request #142 is already open.
索引モデルが issue の本文から書いたものです。
説明
Bug Description
A listener registered by its DI service name cannot be removed using the object returned by getListeners(). The original registration remains active, and registering the returned object again causes duplicate callbacks. This prevents temporarily suspending a resolved listener through the public event manager API.
Environment
Reproduced with nettrine/orm v0.10.1 (480480c92b0d2f35165fa3e478584cef60fac394), Nette DI3.2.7, Doctrine EventManager2.1.1 and PHP8.5.12. The same lookup mismatch is present in upstream master f2fba56a1a29f3568a378eeaa50628888671d5e8. No database, EntityManager, application bootstrap or custom EventManager subclass is needed.
Steps To Reproduce
In a Composer project with nettrine/orm:0.10.1 installed, save this as reproduce.php in the project root and run php reproduce.php:
<?php declare(strict_types = 1);
require 'vendor/autoload.php';
use Doctrine\Common\EventArgs;
use Nette\DI\Container;
use Nettrine\ORM\Events\ContainerEventManager;
final class ReproducerListener
{
public int $calls = 0;
public function onClear(EventArgs $args): void
{
$this->calls++;
}
}
$listener = new ReproducerListener();
$container = new Container();
$container->addService('listener', static fn (): ReproducerListener => $listener);
$events = new ContainerEventManager($container);
$events->addEventListener('onClear', 'listener');
$resolved = array_values($events->getListeners('onClear'))[0];
$events->removeEventListener('onClear', $resolved);
printf("Listeners after removal: %d\n", count($events->getListeners('onClear')));
$events->addEventListener('onClear', $resolved);
$events->dispatchEvent('onClear');
printf("Calls after one dispatch: %d\n", $listener->calls);
Actual Behavior
Listeners after removal: 1
Calls after one dispatch: 2
Expected Behavior
Listeners after removal: 0
Calls after one dispatch: 1
After removal, the event should have no listeners. Registering the same object again should result in exactly one callback for one dispatch.
Cause
Service registrations retain a service@<name> key after resolution, while object removal looks up the object hash. Re-adding the object creates a second registration. Removal and restoration should work by listener identity while preserving lazy construction, order and subscriptions to other events.
Separate static-analysis context
The full upstream master check with PHPStan 2.3.5 / strict-rules 2.1.1 reports one existing variable.undefined diagnostic for the Binder-bound $this in src/ManagerRegistry.php:54. It is identical on the unchanged master and the listener correction. Ten earlier stable-version diagnostics are already fixed by upstream commits 20cfc18 and f2fba56. They are not part of this listener defect. The proposed upstream listener branch adds no analysis suppression or Binder API change.
- 主要言語
- PHP
- スター
- 60
- フォーク
- 33
- PR マージ指標
- 30日以内にマージされた PR はありません
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートなし
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
似ている issue
-
bug
難易度 1/5 1時間未満 初心者へのやさしさ 85/100
メンテナーはふだん 1 日以内に返信
-
難易度 1/5 1時間未満 初心者へのやさしさ 82/100
-
難易度 1/5 1時間未満 初心者へのやさしさ 85/100
Automattic/static-site-importer#3129 ·
メンテナーはふだん 1 日以内に返信
-
Group 2 - Data Storage | Tripal DBX | Chado Group 5 - Search | ElasticSearch | Views Priority - Medium
難易度 2/5 1〜3時間 初心者へのやさしさ 74/100
-
category::bug code priority::normal
難易度 1/5 1〜3時間 初心者へのやさしさ 85/100
e0ipso/simple_oauth_21#58 ·
メンテナーはふだん 1 日以内に返信