ContainerEventManager cannot remove a service listener by its resolved object
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 35/100
Línea de trabajo
Start with ContainerEventManager and the service registration, resolution, and removal paths described in the issue. Run the supplied reproduce.php script to confirm that removal leaves a listener registered and one dispatch calls it twice after re-adding. Done means removal by the resolved object leaves no listener, and re-adding it produces exactly one callback; linked pull request #142 is already open.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Bug Description
A listener registered by its DI service name cannot be removed using the object returned by getListeners(). The original registration remains active, and registering the returned object again causes duplicate callbacks. This prevents temporarily suspending a resolved listener through the public event manager API.
Environment
Reproduced with nettrine/orm v0.10.1 (480480c92b0d2f35165fa3e478584cef60fac394), Nette DI3.2.7, Doctrine EventManager2.1.1 and PHP8.5.12. The same lookup mismatch is present in upstream master f2fba56a1a29f3568a378eeaa50628888671d5e8. No database, EntityManager, application bootstrap or custom EventManager subclass is needed.
Steps To Reproduce
In a Composer project with nettrine/orm:0.10.1 installed, save this as reproduce.php in the project root and run php reproduce.php:
<?php declare(strict_types = 1);
require 'vendor/autoload.php';
use Doctrine\Common\EventArgs;
use Nette\DI\Container;
use Nettrine\ORM\Events\ContainerEventManager;
final class ReproducerListener
{
public int $calls = 0;
public function onClear(EventArgs $args): void
{
$this->calls++;
}
}
$listener = new ReproducerListener();
$container = new Container();
$container->addService('listener', static fn (): ReproducerListener => $listener);
$events = new ContainerEventManager($container);
$events->addEventListener('onClear', 'listener');
$resolved = array_values($events->getListeners('onClear'))[0];
$events->removeEventListener('onClear', $resolved);
printf("Listeners after removal: %d\n", count($events->getListeners('onClear')));
$events->addEventListener('onClear', $resolved);
$events->dispatchEvent('onClear');
printf("Calls after one dispatch: %d\n", $listener->calls);
Actual Behavior
Listeners after removal: 1
Calls after one dispatch: 2
Expected Behavior
Listeners after removal: 0
Calls after one dispatch: 1
After removal, the event should have no listeners. Registering the same object again should result in exactly one callback for one dispatch.
Cause
Service registrations retain a service@<name> key after resolution, while object removal looks up the object hash. Re-adding the object creates a second registration. Removal and restoration should work by listener identity while preserving lazy construction, order and subscriptions to other events.
Separate static-analysis context
The full upstream master check with PHPStan 2.3.5 / strict-rules 2.1.1 reports one existing variable.undefined diagnostic for the Binder-bound $this in src/ManagerRegistry.php:54. It is identical on the unchanged master and the listener correction. Ten earlier stable-version diagnostics are already fixed by upstream commits 20cfc18 and f2fba56. They are not part of this listener defect. The proposed upstream listener branch adds no analysis suppression or Binder API change.
- Lenguaje dominante
- PHP
- Estrellas
- 60
- Forks
- 33
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Sin plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Issues similares
-
Activity page icons previewAbiertobug
Dificultad 1/5 Menos de una hora Aptitud para principiantes 85/100
Los mantenedores suelen responder en 1 día
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 82/100
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 85/100
Automattic/static-site-importer#3129 ·
Los mantenedores suelen responder en 1 día
-
Group 2 - Data Storage | Tripal DBX | Chado Group 5 - Search | ElasticSearch | Views Priority - Medium
Dificultad 2/5 1-3 horas Aptitud para principiantes 74/100
-
category::bug code priority::normal
Dificultad 1/5 1-3 horas Aptitud para principiantes 85/100
e0ipso/simple_oauth_21#58 ·
Los mantenedores suelen responder en 1 día