fix!(lua.endpoints): allow use/sell consumables during SMODS_BOOSTER_OPENED

オープン
  • 何か問題がありますか？
#202 コメント 0 件 リアクション 0 件 担当者 1 名 GitHub で見る

@S1M0N38 がすでに取り組んでいます。

2026年7月1日 から。

評価

この issue はまだ評価されていません。

説明

completed-in-dev

The use and sell endpoints reject valid actions during SMODS_BOOSTER_OPENED that the game actually permits. Verified against the patched source in vendors/lovely/dump/.

use — missing state entirely

src/lua/endpoints/use.lua has requires_state = { SELECTING_HAND, SHOP }, so using a consumable from inventory while a pack is open is blocked with INVALID_STATE.

The game explicitly allows it. SMODS patches Card:can_use_consumeable (card.lua:1818 in the dump) to include the state:

if G.STATE == G.STATES.SELECTING_HAND or G.STATE == G.STATES.TAROT_PACK
   or G.STATE == G.STATES.SPECTRAL_PACK or G.STATE == G.STATES.PLANET_PACK
   or G.STATE == G.STATES.SMODS_BOOSTER_OPENED then

Using an inventory consumable mid-pack is a non-destructive interrupt (TAROT_INTERRUPT): use_card saves prev_state, runs the consumable, then restores the pack — G.GAME.pack_choices is unchanged and the pack stays open (functions/button_callbacks.lua:2291-2305).

sell — wrongly restricted to Buffoon packs

src/lua/endpoints/sell.lua:58-72 rejects every sell unless the open pack is a Buffoon pack:

if G.STATE == G.STATES.SMODS_BOOSTER_OPENED then
  ... if pack_set ~= "Joker" then
    send_response({ message = "Can only sell jokers when a Buffoon pack is open", ... })

The game has no such restriction. Card:can_sell_card (card.lua:1896 in the dump) only checks area.config.type == joker — and G.consumeables is created with type = 'joker' (game.lua:2291), so jokers and consumables are sellable during any pack type. Freeing a slot before picking from a pack is intended gameplay.

Fix

  1. use.lua: add G.STATES.SMODS_BOOSTER_OPENED to requires_state. Existing max_highlighted target logic already matches the game. Hand-target consumables only apply when the pack exposes a hand (draw_hand packs — same condition rearrange.lua:88-89 already uses).
  2. sell.lua: remove the Buffoon-only guard; keep the universal can_sell_card checks (not during play, not eternal).

Both gaps are untested — test_sell.py has no SMODS_BOOSTER_OPENED cases; test_use.py asserts NOT_ALLOWED in states the game permits.

Ref: #156 (subset — sell joker in Buffoon pack)

主要言語
Python
スター
80
フォーク
23
30日以内にマージされた PR はありません

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

coder/balatrobot のほかの issue

coder/balatrobot の issue をすべて見る

似ている issue

Python の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。