destination-port/app-port should be configurable in map-route like with the new beta flag for destination-protocol/app-protocol
メンテナーはふだん 3 日以内に返信
まだ誰も着手していません。
評価
調査の方向性
map-route コマンドと、既存の destination-protocol/app-protocol の beta-flag 処理から始め、次に funcf/cli PR #1 の提案と比較します。map-route でカスタム宛先の app-port を設定でき、パラメーター名の決定と関連するヘルプまたはドキュメントが解決されれば完了です。
索引モデルが issue の本文から書いたものです。
説明
Please provide details on the following items. Failure to do so may result in deletion of your feature request.
What's the user value of this feature request?
Users can directly map routes to custom app ports, e.g. for Docker apps with multiple ports, via cf cli without having to patch the destinations array via API call later on.
This would simplify this documented process: https://docs.cloudfoundry.org/devguide/custom-ports.html
to a simple map-route command like comparable to the beta flag for HTTP/2 protocol routes:
https://docs.cloudfoundry.org/adminguide/supporting-http2.html#application
Who is the functionality for?
Customers who use docker apps with multiple ports that should be exposed as different routes and
customers who need to expose a non-standard (8080) port for buildpack apps and a different port than the lowest port for docker apps.
How often will this functionality be used by the user?
Hard to say, once for these special apps.
Who else is affected by the change?
No breaking change as just another parameter is added and it is completing the destination object fields (besides the recently added destination-protocol as app-protocol map-route parameter now just the destination-port as app-port parameter is missing).
Is your feature request related to a problem? Please describe.
It is a very inconvenient and error-prone process to get the route GUID for the app with the wrong default port at first and then patching it with the API switching context and involving several steps even with cf curl.
Describe the solution you'd like
I have a proposal running in the https://github.com/funcf/cli repo on the main branch there.
The PR to include it was this one: https://github.com/funcf/cli/pull/1
Actually this fork was created to contribute to this feature and other CF CLI enhancements. :-)
I actually created a PR to this repo by accident first and closed it directly, because I did not want to bother anyone with a PR that does not follow the description template from the start: https://github.com/cloudfoundry/cli/pull/3612
But if that is the fastest path, then I can fix the pre-conditions and we can reopen it with an updated description.
Describe alternatives you've considered
After the CF Day Europe @itsouvalas and I hacked on this issue and this simple extension following the example of the destination-protocol as app-protocol parameter was the most obvious case so we did not consider other paths.
Since there is another open issue (https://github.com/cloudfoundry/cli/issues/3606) stating that the parameters are not matching the docs (where sometimes destination-protcol was mentioned instead of app-protocol as parameter), we could consider to refactor both to destination-* - however, that would align it more with the CF API on the one hand, but also introduce a breaking change. It is stated in the cli help that it might change at any time - but app-* as a prefix might also be fine (and shorter) and updating the docs is faster as well.
Additional context
Note:
As of the GA of the v7 CLI, the v6 line is no longer under active development and will be updated only to patch CVEs or fix severe blocking defects with no workarounds.
- 主要言語
- Go
- スター
- 1.9k
- フォーク
- 989
- 平均マージ
- 4日 15時間
- マージ済み PR（30日）
- 8
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートあり
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
cloudfoundry/cli のほかの issue
-
難易度 4/5 3〜5日 初心者へのやさしさ 52/100
cloudfoundry/cli#3866 ·
メンテナーはふだん 3 日以内に返信
-
難易度 4/5 3〜5日 初心者へのやさしさ 45/100
cloudfoundry/cli#3863 · コメント 2 件 · リアクション 1 件 ·
メンテナーはふだん 3 日以内に返信
-
難易度 5/5 1週間以上 初心者へのやさしさ 45/100
cloudfoundry/cli#3851 · コメント 1 件 · リアクション 1 件 ·
メンテナーはふだん 3 日以内に返信
-
難易度 3/5 1〜2日 初心者へのやさしさ 62/100
cloudfoundry/cli#3794 ·
メンテナーはふだん 3 日以内に返信
-
難易度 3/5 1〜2日 初心者へのやさしさ 48/100
cloudfoundry/cli#3787 · コメント 1 件 ·
メンテナーはふだん 3 日以内に返信
cloudfoundry/cli の issue をすべて見る
似ている issue
-
cvss-severity:high devguard l3montree-cybersecurity/devguard/devguard pkg:golang/github.com/l3montree-dev/devguard risk:low state:open
難易度 2/5 1〜3時間 初心者へのやさしさ 65/100
l3montree-dev/devguard#3146 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
CLI
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
databricks/cli#6910 ·
メンテナーはふだん 1 日以内に返信
-
Table presenter appends a spurious ", ..." to the FIX column when all fix versions are already shownオープン
難易度 2/5 1〜3時間 初心者へのやさしさ 88/100
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
canonical/microceph#900 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
vulncheck or vulndb
難易度 2/5 1〜3時間 初心者へのやさしさ 84/100
メンテナーはふだん 1 日以内に返信