destination-port/app-port should be configurable in map-route like with the new beta flag for destination-protocol/app-protocol
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 35/100
Direzione di ricerca
Inizia con il comando map-route e la relativa gestione esistente dei beta-flag di destination-protocol/app-protocol, quindi confronta la proposta in funcf/cli PR #1. Il lavoro è completato quando map-route può configurare app-port per destinazioni personalizzate e sono state risolte la decisione sulla denominazione del parametro e la relativa guida o documentazione.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Please provide details on the following items. Failure to do so may result in deletion of your feature request.
What's the user value of this feature request?
Users can directly map routes to custom app ports, e.g. for Docker apps with multiple ports, via cf cli without having to patch the destinations array via API call later on.
This would simplify this documented process: https://docs.cloudfoundry.org/devguide/custom-ports.html
to a simple map-route command like comparable to the beta flag for HTTP/2 protocol routes:
https://docs.cloudfoundry.org/adminguide/supporting-http2.html#application
Who is the functionality for?
Customers who use docker apps with multiple ports that should be exposed as different routes and
customers who need to expose a non-standard (8080) port for buildpack apps and a different port than the lowest port for docker apps.
How often will this functionality be used by the user?
Hard to say, once for these special apps.
Who else is affected by the change?
No breaking change as just another parameter is added and it is completing the destination object fields (besides the recently added destination-protocol as app-protocol map-route parameter now just the destination-port as app-port parameter is missing).
Is your feature request related to a problem? Please describe.
It is a very inconvenient and error-prone process to get the route GUID for the app with the wrong default port at first and then patching it with the API switching context and involving several steps even with cf curl.
Describe the solution you'd like
I have a proposal running in the https://github.com/funcf/cli repo on the main branch there.
The PR to include it was this one: https://github.com/funcf/cli/pull/1
Actually this fork was created to contribute to this feature and other CF CLI enhancements. :-)
I actually created a PR to this repo by accident first and closed it directly, because I did not want to bother anyone with a PR that does not follow the description template from the start: https://github.com/cloudfoundry/cli/pull/3612
But if that is the fastest path, then I can fix the pre-conditions and we can reopen it with an updated description.
Describe alternatives you've considered
After the CF Day Europe @itsouvalas and I hacked on this issue and this simple extension following the example of the destination-protocol as app-protocol parameter was the most obvious case so we did not consider other paths.
Since there is another open issue (https://github.com/cloudfoundry/cli/issues/3606) stating that the parameters are not matching the docs (where sometimes destination-protcol was mentioned instead of app-protocol as parameter), we could consider to refactor both to destination-* - however, that would align it more with the CF API on the one hand, but also introduce a breaking change. It is stated in the cli help that it might change at any time - but app-* as a prefix might also be fine (and shorter) and updating the docs is faster as well.
Additional context
Note:
As of the GA of the v7 CLI, the v6 line is no longer under active development and will be updated only to patch CVEs or fix severe blocking defects with no workarounds.
- Lingua principale
- Go
- Stelle
- 1.9k
- Fork
- 990
- Merge medio
- 1g 7h
- PR unite (30g)
- 8
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di cloudfoundry/cli
-
Difficoltà 4/5 3-5 giorni Idoneità per principianti 52/100
cloudfoundry/cli#3866 ·
-
Difficoltà 4/5 3-5 giorni Idoneità per principianti 45/100
cloudfoundry/cli#3863 · 2 commenti ·
-
Difficoltà 5/5 Più di una settimana Idoneità per principianti 45/100
cloudfoundry/cli#3851 · 1 commento · 1 reazione ·
-
Add zsh shell completion Aperta
Difficoltà 3/5 1-2 giorni Idoneità per principianti 62/100
cloudfoundry/cli#3794 ·
-
Difficoltà 3/5 1-2 giorni Idoneità per principianti 48/100
cloudfoundry/cli#3787 · 1 commento ·
Tutte le issue di cloudfoundry/cli
Issue simili
-
agentic-workflows
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
-
agentic-workflows
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
microsoft/agent-framework-go#1179 ·
-
bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
-
[Bug]: OLLAMA_KEEP_ALIVE="5m" / "24h" crashes Ollama embedding and vision models with ValueError Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
infiniflow/ragflow#20223 · 1 reazione ·
-
bug needs triage pkg/translator/faro
Difficoltà 2/5 1-3 ore Idoneità per principianti 88/100
open-telemetry/opentelemetry-collector-contrib#51484 · 1 commento ·