Hacktoberfest 2026:メンテナが10月に向けて印を付けた、オープンで初心者向けの issue。 Hacktoberfest の issue を見る

Extend `requireNodeAddon(path)` to support more use-cases

オープン
#91 コメント 6 件 リアクション 0 件 担当者 1 名 GitHub で見る

@mani3xis がすでに取り組んでいます。

2025年5月16日 から。

  • #104 @mani3xis による — オープン

評価

この issue はまだ評価されていません。

説明

Context

Currently, the requireNodeAddon() function requires only 1 string argument, which was expected to be a relative path to the compiled Node add-on. This worked great for the first few simple PoCs and demos, but it start showing its age and limitations already. In the meantime @kraenhansen in #12 added support for hashing the module paths to solve the issues of name clashes when modules are being packaged, which was later replaced by #32.

Problem statement

  1. The current solution does not support addons, which are imported by specifying just the package name, whose package.json specifies the main field.
  2. Leaking abstraction (exposes implementation details)

Proposed solution

Adding additional parameters to requireNodeAddon() that would enable the platform's add-on loader to resolve the path and try a few of them. My current suggestion is to have requireNodeAddon(requiredPath: string, targetPackageName: string, fromSubpath: string) where:

  • requiredPath is (in most cases) the original relative path passed to the require() call. If this path was not relative (starting with . or ..) then it should be the package name which will be resolved by looking up the main field, making this argument a relative subpath again.
  • packageName should be the name of the package that this add-on is expected to be in. Please note that such package name might be scoped, therefore - for simplicity - I've decided to keep it separated from the subpath.
  • fromSubpath is the relative path (subpath) of the file that issued the call to the require() function. This parameter is needed to resolve the package-relative path where the add-on is supposed to be.
Example use case 1

Somebody in ./src/index.js within package @callstack/foo wrote:

const module = require('./build/Release/foo.node');

Our Babel plugin should replace it with following:

const module = requireNodeAddon('./build/Release/foo.node', '@callstack/foo', './src/index.js');

In this case, the native loader would be able to resolve the relative path by combining ./build/Release/foo.node on top of ./src/index.js, resulting in ./src/build/Release/foo.node - which should be added to the search paths.

[!NOTE]
If the path would include the package name (especially when it's scoped), like @callstack/foo/src/build/Release/foo.node, then separating the package name from the subpath would be a little bit more convoluted (we would need to parse it). Passing those as separate arguments gives us those "for free".

Example use-case 2

Somebody in the package @callstack/foo set the main field in their package.json to ./foo.node. A different user in their package (say whatever) writes:

const { foofighter } = require('@callstack/foo');

then our Babel plugin should output:

const { foofighter } = requireNodeAddon('./foo.node', '@callstack/foo', './package.json');

Following the steps from the "algorithm" above, the relative path would be resolved to ./foo.node (it used the path from main and ./package.json gives ./), which will be expected to be in the @callstack/foo package. The exact value of the last argument is not that important here (can be ./ or . as well).

Example use-case 3

Somebody in ./src/wrapper.js that's part of package foo wrote:

const fs = require('node:fs');

Our Babel plugin is expected to output this instead:

const fs = requireNodeAddon('node:fs', 'foo', './src/wrapper.js');

More flexible loader

One of the main goals of this proposal would be to "hide" the resolution algorithm in native code. The JavaScript side should not care whether the names are hashed or changed in any other way. The closer the original Node.js code, the better. Those 3 separate arguments: requiredPath, targetPackageName and fromSubpath gives more flexibility to the native loader. If all the addons are flattened into a single directory (like for iOS), the JS does not care -- the native loader will be able to implement this logic and try different search paths and variants.

Lastly, it shouldn't be hard to adapt this approach to support ES modules that use import and export.

主要言語
TypeScript
スター
188
フォーク
10
平均マージ
2日 17時間
マージ済み PR(30日)
3

コントリビューションガイド

このリポジトリのコントリビューションガイドは索引されていません

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

callstackincubator/react-native-node-api のほかの issue

callstackincubator/react-native-node-api の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。