socket_timeout includes queueing time in a shared, unconfigurable, process-wide thread pool, causing misleading QueryTimeoutErrors on unrelated queries
まだ誰も着手していません。
評価
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 初心者へのやさしさ
- 35/100
- issue の種類
- バグ
- 明瞭さ
- おおむね明確
- 活発さ
- 活発
- 技術スタック
- postgresql, python
- 領域
- backend, databases, performance
調査の方向性
Start with utils/decorators.py, especially timeout() and preserve_transaction_status_with_timeout(), then trace services_container.get_thread_pool("DriverDialectExecutor"). Reproduce the reported contention with concurrent pg_sleep(8) calls and SELECT 1. Done should establish and test an agreed fix for queueing time and executor concurrency, rather than merely documenting the behavior.
索引モデルが issue の本文から書いたものです。
説明
Describe the bug
socket_timeout is enforced by submitting the underlying driver call to a shared ThreadPoolExecutor and calling future.result(timeout=socket_timeout) (utils/decorators.py, timeout() / preserve_transaction_status_with_timeout()). That executor is a single, process-wide singleton — services_container.get_thread_pool("DriverDialectExecutor") — shared by every connection and every cursor operation in the process, not scoped per-connection and not related to the size of the caller's own DB connection pool. Its size is never set explicitly anywhere in the wrapper (get_thread_pool(name) is always called with no max_workers), so it falls back to Python's generic ThreadPoolExecutor default: min(32, os.cpu_count() + 4).
Because future.result(timeout=...) starts its clock at executor.submit(), not at the moment the submitted call actually starts running, any time a submission spends queued behind other in-flight driver calls counts fully against socket_timeout. If enough concurrent driver calls are in flight to fill that small, fixed-size pool (very plausible for any app that pools more DB connections than cpu_count + 4, which is a common and reasonable configuration), unrelated and otherwise-trivially-fast queries start timing out — not because they're slow, but because they never got a worker thread in time. The resulting QueryTimeoutError is indistinguishable from a genuine slow query/lock wait, which makes this very hard to diagnose: the error attributes to whatever SQL happened to be queued, with no indication the real cause is thread-pool contention from unrelated concurrent calls elsewhere in the process.
Expected Behavior
socket_timeout should bound the time the actual driver/socket operation takes to execute, not scheduling delay inside an internal, undocumented thread pool. At minimum, the pool used to enforce this timeout should either scale with the caller's configured connection concurrency (e.g. pool size) or be explicitly configurable, so that setting a connection pool size larger than cpu_count + 4 doesn't silently create a hidden concurrency ceiling that's lower than the connection pool itself.
What plugins are used? What other connection properties were set?
plugins="iam", wrapper_dialect="rds-pg", wrapper_driver_dialect="psycopg"
Current Behavior
Under a burst of concurrent database contention (in our case: multiple concurrent transactions blocked on a Postgres row lock, each occupying a worker thread in DriverDialectExecutor for up to their full socket_timeout while waiting on Cursor.execute), a completely unrelated query — targeting a different table with no lock contention of its own — also raised QueryTimeoutError on Cursor.execute, having exceeded its 5 second socket_timeout.
We confirmed that this specific statement showed negligible database-side load and an average execution latency of 0.84ms across the whole incident window — i.e., the statement itself was never slow at the database. This is consistent with the delay happening entirely client-side: the call was queued in the shared DriverDialectExecutor pool behind the other concurrently-blocked calls, and the queueing time alone exceeded the 5 second timeout before the query was ever dispatched to Postgres.
Reproduction Steps
This can be reproduced by saturating the shared executor with concurrent slow calls:
- On a host/container where
os.cpu_count()is small (e.g. 2, giving a default pool size ofmin(32, 2+4) = 6), openN > 6connections viaAwsWrapperConnection.connect(psycopg.connect, ..., socket_timeout=5). - On
N - 1of those connections, concurrently (e.g. one thread per connection) execute a query that runs longer thansocket_timeoutbut well under the connection's own network timeout — e.g.SELECT pg_sleep(8)— so each of those calls occupies aDriverDialectExecutorworker thread for ~8 seconds. - On one additional, otherwise-idle connection, concurrently execute a trivial, instantaneous query:
SELECT 1. - Observe: the
SELECT 1call raisesaws_advanced_python_wrapper.QueryTimeoutError(Cursor.executetimeout) even thoughSELECT 1never reaches the database in a way that would take anywhere near 5 seconds — it's queued behind the 6pg_sleep(8)calls in the shared pool and itsfuture.result(timeout=5)clock (started at submission) expires first.
Possible Solution
A few options, roughly in order of how much they'd change existing behavior:
- Expose the
DriverDialectExecutor(and equivalent per-dialect) pool size as a configurable wrapper property (e.g.DRIVER_DIALECT_EXECUTOR_MAX_WORKERS), defaulting to something scaled to expected DB concurrency rather thancpu_count + 4. - Size the pool based on the connection provider's own pool configuration (e.g.
pool_size + max_overflow) when a pooled connection provider is in use, so it can't become a stricter bottleneck than the connection pool it's serving. - At minimum, document clearly that
socket_timeoutincludes time spent queued in a shared, process-wide thread pool of this default size, so callers can reason about whether their expected concurrent query volume can exceed it.
Additional Information/Context
No response
The AWS Advanced Python Wrapper version used
3.0.0
python version used
3.13.15
Operating System and version
Debian 13 (Trixie)
- 主要言語
- Python
- スター
- 99
- フォーク
- 22
- 平均マージ
- 1日 7時間
- マージ済み PR(30日)
- 4
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートあり
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
aws/aws-advanced-python-wrapper のほかの issue
-
bug
難易度 4/5 3〜5日 初心者へのやさしさ 72/100
aws/aws-advanced-python-wrapper#1276 · コメント 1 件 ·
-
bug
難易度 4/5 3〜5日 初心者へのやさしさ 48/100
aws/aws-advanced-python-wrapper#1275 · コメント 1 件 ·
-
Support for PyMySQLオープンenhancement
難易度 3/5 1〜2日 初心者へのやさしさ 45/100
aws/aws-advanced-python-wrapper#752 · コメント 1 件 ·
aws/aws-advanced-python-wrapper の issue をすべて見る
似ている issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
メンテナーはふだん 3 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 88/100
modelcontextprotocol/python-sdk#3648 ·
メンテナーはふだん 1 日以内に返信
-
docs good first issue
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
VenetoStato/giorgio#6 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 74/100
メンテナーはふだん 1 日以内に返信
-
難易度 1/5 1時間未満 初心者へのやさしさ 70/100
EclipseFdn/open-vsx.org#13831 ·
メンテナーはふだん 1 日以内に返信