Bug: publication_approved never accesses errors param

まず lambda_handler エントリポイントと publication_approved メソッドを見つけ、次に errors の値がそれらの間でどのように渡されているかを追跡します。この issue には publication_approved が errors をどう扱うべきかが記載されていないため、コードを変更する前に意図された動作を確認してください。パラメーターに定義済みでテストされた用途があるか、一貫して削除されていれば完了です。

Expected Behaviour

publication_approved method never access errors

Current Behaviour

No issue, parameter is never used

Code snippet

def lambda_handler(event, context):
    """Main entry point for Property Approval lambda function

    Parameters
    ----------
    event : API Gateway Lambda Proxy Request
        The event passed to the function.
    context : AWS Lambda Context
        The context for the Lambda function.

    Returns
    -------
    Success message upon successful storage of the approval outcome into DynamoDB
    """

    logger.info(event)

    errors = None if 'workflowErrors' not in event['detail'] else event['detail'].pop('workflowErrors')

    # Deserialize event into strongly typed object
    awsEvent:AWSEvent = Marshaller.unmarshall(event, AWSEvent)  # type: ignore
    detail:PublicationEvaluationCompleted = awsEvent.detail  # type: ignore

    return publication_approved(detail, errors)def lambda_handler(event, context):
    """Main entry point for Property Approval lambda function

    Parameters
    ----------
    event : API Gateway Lambda Proxy Request
        The event passed to the function.
    context : AWS Lambda Context
        The context for the Lambda function.

    Returns
    -------
    Success message upon successful storage of the approval outcome into DynamoDB
    """

    logger.info(event)

    errors = None if 'workflowErrors' not in event['detail'] else event['detail'].pop('workflowErrors')

    # Deserialize event into strongly typed object
    awsEvent:AWSEvent = Marshaller.unmarshall(event, AWSEvent)  # type: ignore
    detail:PublicationEvaluationCompleted = awsEvent.detail  # type: ignore

    return publication_approved(detail, errors)

Possible Solution

No response

Steps to Reproduce

N/A

Debugging logs

No response