Start: prerender forces trailing slashes, causing unnecessary redirects with trailingSlash: "never"

オープン
#8,850 コメント 1 件 リアクション 1 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

  • #8916 @okxint による — マージされずにクローズ

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
72/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
node.js, react, typescript, vite

調査の方向性

Start with @tanstack/start-plugin-core/src/prerender.ts, where the issue says the preview fetch URL is built using withTrailingSlash and withBase; trace how the trailing slash policy and base path reach that call. Use the linked reproducer’s npm ci and npm run build, then inspect its [preview-request] output. Done when explicit slashless paths with trailingSlash: 'never' are requested without the extra 307 redirect.

索引モデルが issue の本文から書いたものです。

説明

Which project does this relate to?

Start

Describe the bug

When the router uses trailingSlash: 'never', prerendering still appends a trailing
slash to each requested page URL. The router then returns a 307 redirect to the
slashless URL, and prerender follows it. This adds an unnecessary request for every
non-root page.

This happens with an explicit list of unique, slashless paths, with both
autoStaticPathsDiscovery and crawlLinks disabled. It reproduces with the default
Node preview server, without Cloudflare or any other adapter.

Complete minimal reproducer

https://github.com/R4ULtv/tanstack-start-prerender-trailing-slash

Steps to reproduce

  1. Clone the reproduction repository.
  2. Run npm ci.
  3. Run npm run build.
  4. Inspect the [preview-request] lines in the output.

The reproduction has one dynamic route (/page/$id) and three explicit paths:
/page/1, /page/2, and /page/3. All input paths are slashless.

For each path the output shows:

[prerender] Crawling: /page/1
[preview-request] GET /page/1/ -> 307 Location: /page/1
[preview-request] GET /page/1 -> 200

The build succeeds, but each page requires two requests. The reproduction's Vite
plugin only logs the preview requests and response status/Location header; it does
not modify them. Setting PAGE_COUNT to 1 is sufficient to reproduce the issue.

Expected behavior

With trailingSlash: 'never', prerender should request slashless URLs directly,
avoiding the redirect for each page. URL normalization should account for the
configured trailing-slash policy and base path.

Platform

  • @tanstack/react-start: 1.169.4
  • @tanstack/react-router: 1.170.46
  • @tanstack/start-plugin-core (transitive): 1.171.55
  • React / React DOM: 19.3.1
  • Vite: 8.3.5
  • Node.js: 24.22.2
  • OS: macOS (Apple Silicon)
  • Adapter: default Node preview server

Additional context

In @tanstack/start-plugin-core/src/prerender.ts, the URL passed to fetch is
constructed with:

withTrailingSlash(withBase(page.path, routerBasePath))

This forces the slash even though the provided page path is already canonical.

The reproduction also contains an optional npm run benchmark that measures
increasing page counts, with four alternating-order runs per variant. It compares
current behavior with a preview-only rewrite that avoids the redirect, checks
request counts and generated output, and produces a self-contained HTML report
with the raw measurements. These are synthetic local Node results at concurrency
1; the percentage improvement is workload-specific and excludes deployment.

Recorded benchmark artifacts:

I mentioned this separately in #8483, which primarily concerns CPU parallelism.
This report isolates the redirect behavior independently of concurrency.

Related: #6978 / #7070 address duplicate discovered paths. This report concerns
additional HTTP requests for explicit, unique paths with discovery/crawling
disabled, so normalizing discovered paths alone would not resolve it.

Prepared with AI assistance. The reproduction and benchmark builds were executed and verified locally.

主要言語
TypeScript
スター
15.3k
フォーク
1.9k
平均マージ
1日 5時間
マージ済み PR(30日)
46

環境構築

Codespaces で開く

このプロジェクトの開発コンテナを、あなたの GitHub アカウントでブラウザ上に起動します。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

TanStack/router のほかの issue

TanStack/router の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。