Start: prerender forces trailing slashes, causing unnecessary redirects with trailingSlash: "never"
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
- #8916 di @okxint — chiusa senza merge
Valutazione
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 72/100
- Tipo di issue
- Bug
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Attiva
- Stack tecnologico
- node.js, react, typescript, vite
- Ambito
- backend, performance
Direzione di ricerca
Start with @tanstack/start-plugin-core/src/prerender.ts, where the issue says the preview fetch URL is built using withTrailingSlash and withBase; trace how the trailing slash policy and base path reach that call. Use the linked reproducer’s npm ci and npm run build, then inspect its [preview-request] output. Done when explicit slashless paths with trailingSlash: 'never' are requested without the extra 307 redirect.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Which project does this relate to?
Start
Describe the bug
When the router uses trailingSlash: 'never', prerendering still appends a trailing
slash to each requested page URL. The router then returns a 307 redirect to the
slashless URL, and prerender follows it. This adds an unnecessary request for every
non-root page.
This happens with an explicit list of unique, slashless paths, with both
autoStaticPathsDiscovery and crawlLinks disabled. It reproduces with the default
Node preview server, without Cloudflare or any other adapter.
Complete minimal reproducer
https://github.com/R4ULtv/tanstack-start-prerender-trailing-slash
Steps to reproduce
- Clone the reproduction repository.
- Run
npm ci. - Run
npm run build. - Inspect the
[preview-request]lines in the output.
The reproduction has one dynamic route (/page/$id) and three explicit paths:
/page/1, /page/2, and /page/3. All input paths are slashless.
For each path the output shows:
[prerender] Crawling: /page/1
[preview-request] GET /page/1/ -> 307 Location: /page/1
[preview-request] GET /page/1 -> 200
The build succeeds, but each page requires two requests. The reproduction's Vite
plugin only logs the preview requests and response status/Location header; it does
not modify them. Setting PAGE_COUNT to 1 is sufficient to reproduce the issue.
Expected behavior
With trailingSlash: 'never', prerender should request slashless URLs directly,
avoiding the redirect for each page. URL normalization should account for the
configured trailing-slash policy and base path.
Platform
@tanstack/react-start: 1.169.4@tanstack/react-router: 1.170.46@tanstack/start-plugin-core(transitive): 1.171.55- React / React DOM: 19.3.1
- Vite: 8.3.5
- Node.js: 24.22.2
- OS: macOS (Apple Silicon)
- Adapter: default Node preview server
Additional context
In @tanstack/start-plugin-core/src/prerender.ts, the URL passed to fetch is
constructed with:
withTrailingSlash(withBase(page.path, routerBasePath))
This forces the slash even though the provided page path is already canonical.
The reproduction also contains an optional npm run benchmark that measures
increasing page counts, with four alternating-order runs per variant. It compares
current behavior with a preview-only rewrite that avoids the redirect, checks
request counts and generated output, and produces a self-contained HTML report
with the raw measurements. These are synthetic local Node results at concurrency
1; the percentage improvement is workload-specific and excludes deployment.
Recorded benchmark artifacts:
- Self-contained HTML report
- Raw measurements and verification metadata (JSON)
- Individual measured runs (CSV)
I mentioned this separately in #8483, which primarily concerns CPU parallelism.
This report isolates the redirect behavior independently of concurrency.
Related: #6978 / #7070 address duplicate discovered paths. This report concerns
additional HTTP requests for explicit, unique paths with discovery/crawling
disabled, so normalizing discovered paths alone would not resolve it.
Prepared with AI assistance. The reproduction and benchmark builds were executed and verified locally.
- Lingua principale
- TypeScript
- Stelle
- 15.3k
- Fork
- 1.9k
- Merge medio
- 1g 5h
- PR unite (30g)
- 46
Preparare l'ambiente
Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di TanStack/router
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 85/100
I maintainer di solito rispondono entro 1 giorno
-
Masked navigation drops the first character of the hash each time (__tempLocation hash missing '#')Forse già presa @hassanabrar202 l’ha presa 8 giorni fa. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
I maintainer di solito rispondono entro 1 giorno
-
router-generator: lazy-load Prettier (costs ~300–450ms per build even when formatting is off)Forse già presa @Sheraff l’ha presa 27 giorni fa. Apertapackage: router-generator performance
Difficoltà 2/5 1-3 ore Idoneità per principianti 85/100
I maintainer di solito rispondono entro 1 giorno
-
router-generator: sibling `physical()` subtrees in a virtual route config generate duplicate identifiersForse già presa @Sheraff l’ha presa 27 giorni fa. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
I maintainer di solito rispondono entro 1 giorno
-
docs(router): clarify static title fallback in SPA modeForse già presa @Rohan-Dedhia l’ha presa 17 giorni fa. Aperta
Difficoltà 1/5 1-3 ore Idoneità per principianti 62/100
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di TanStack/router
Issue simili
-
[BUG]: Shared links drop the configured basePath on GitHub PagesForse già presa @anshulchikhale30-p l’ha presa oggi. Apertabug
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 88/100
StabilityNexus/IdentityTokens-EVM-Frontend#182 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
Add: GTrekkerApertacheck:passed streams:add
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 72/100
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
Koenkk/zigbee-herdsman-converters#13900 ·
I maintainer di solito rispondono entro 1 giorno
-
area: ui Bug Payload OSS
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 88/100
payloadcms/payload#19839 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 88/100
jeanibarz/knowledge-base-mcp-server#1291 ·
I maintainer di solito rispondono entro 1 giorno