Start: prerender forces trailing slashes, causing unnecessary redirects with trailingSlash: "never"

Aperta
#8,850 1 commento 1 reazione 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

  • #8916 di @okxint — chiusa senza merge

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
72/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
node.js, react, typescript, vite

Direzione di ricerca

Start with @tanstack/start-plugin-core/src/prerender.ts, where the issue says the preview fetch URL is built using withTrailingSlash and withBase; trace how the trailing slash policy and base path reach that call. Use the linked reproducer’s npm ci and npm run build, then inspect its [preview-request] output. Done when explicit slashless paths with trailingSlash: 'never' are requested without the extra 307 redirect.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Which project does this relate to?

Start

Describe the bug

When the router uses trailingSlash: 'never', prerendering still appends a trailing
slash to each requested page URL. The router then returns a 307 redirect to the
slashless URL, and prerender follows it. This adds an unnecessary request for every
non-root page.

This happens with an explicit list of unique, slashless paths, with both
autoStaticPathsDiscovery and crawlLinks disabled. It reproduces with the default
Node preview server, without Cloudflare or any other adapter.

Complete minimal reproducer

https://github.com/R4ULtv/tanstack-start-prerender-trailing-slash

Steps to reproduce

  1. Clone the reproduction repository.
  2. Run npm ci.
  3. Run npm run build.
  4. Inspect the [preview-request] lines in the output.

The reproduction has one dynamic route (/page/$id) and three explicit paths:
/page/1, /page/2, and /page/3. All input paths are slashless.

For each path the output shows:

[prerender] Crawling: /page/1
[preview-request] GET /page/1/ -> 307 Location: /page/1
[preview-request] GET /page/1 -> 200

The build succeeds, but each page requires two requests. The reproduction's Vite
plugin only logs the preview requests and response status/Location header; it does
not modify them. Setting PAGE_COUNT to 1 is sufficient to reproduce the issue.

Expected behavior

With trailingSlash: 'never', prerender should request slashless URLs directly,
avoiding the redirect for each page. URL normalization should account for the
configured trailing-slash policy and base path.

Platform

  • @tanstack/react-start: 1.169.4
  • @tanstack/react-router: 1.170.46
  • @tanstack/start-plugin-core (transitive): 1.171.55
  • React / React DOM: 19.3.1
  • Vite: 8.3.5
  • Node.js: 24.22.2
  • OS: macOS (Apple Silicon)
  • Adapter: default Node preview server

Additional context

In @tanstack/start-plugin-core/src/prerender.ts, the URL passed to fetch is
constructed with:

withTrailingSlash(withBase(page.path, routerBasePath))

This forces the slash even though the provided page path is already canonical.

The reproduction also contains an optional npm run benchmark that measures
increasing page counts, with four alternating-order runs per variant. It compares
current behavior with a preview-only rewrite that avoids the redirect, checks
request counts and generated output, and produces a self-contained HTML report
with the raw measurements. These are synthetic local Node results at concurrency
1; the percentage improvement is workload-specific and excludes deployment.

Recorded benchmark artifacts:

I mentioned this separately in #8483, which primarily concerns CPU parallelism.
This report isolates the redirect behavior independently of concurrency.

Related: #6978 / #7070 address duplicate discovered paths. This report concerns
additional HTTP requests for explicit, unique paths with discovery/crawling
disabled, so normalizing discovered paths alone would not resolve it.

Prepared with AI assistance. The reproduction and benchmark builds were executed and verified locally.

Lingua principale
TypeScript
Stelle
15.3k
Fork
1.9k
Merge medio
1g 5h
PR unite (30g)
46

Preparare l'ambiente

Apri in Codespaces

Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di TanStack/router

Tutte le issue di TanStack/router

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.