router.commitLocation is a no-op on 1.170.36 / router-core 1.171.30, so router.navigate() silently does nothing

オープン
#8,479 コメント 2 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

  • #8560 @00200200 による — マージされずにクローズ

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
65/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
javascript, react, typescript

調査の方向性

The issue is in router-core's commitLocation function. Start by examining the changes between versions 1.171.29 and 1.171.30 in the router-core package, focusing on commitLocation and navigate methods. The reproducer in the gist shows the exact failing calls. Run the provided repro.mjs to see the no-op behavior, then trace through the commitLocation logic to see why it doesn't update history. Look at the test suite to understand expected behavior.

索引モデルが issue の本文から書いたものです。

説明

Which project does this relate to?

Router

Describe the bug

On @tanstack/react-router 1.170.36 with @tanstack/router-core 1.171.30, router.navigate() does nothing at all on a router created programmatically. history.location, latestLocation and state.location all stay on the previous entry, the promise resolves undefined, and state.status is back to idle — so there is no pending navigation to await.

It is not path matching or location building. router.buildLocation({ to: ".", search: (p) => ({ ...p, list: "sexes" }) }) returns the correct /operations?tab=lookup-data&list=sexes on both versions. Passing that straight to router.commitLocation({ ...built, replace: true }) moves history on 1.170.35 and does not on 1.170.36. The regression is on the commit side.

Every navigation shape I tried is affected:

probe 1.170.35 1.170.36
to: "." + functional search updater applied no-op
to: "." + object search applied no-op
to: "/operations" + functional updater applied no-op
no to + functional updater applied no-op
to: "/horses/$id" + params (path change) applied no-op

Caveat, stated up front: the router in this reproducer is created programmatically and never rendered through RouterProvider. I have not established whether a mounted router is affected. I am reporting it because this shape is how a lot of test suites drive the router, and because the pair of patch releases changes it.

Complete minimal reproducer

https://gist.github.com/NickyTope/bcf0b4e05e194dc3b39406cc45c6783c

Steps to Reproduce the Bug
mkdir tsr-repro && cd tsr-repro
# take package.json and repro.mjs from the gist
npm i @tanstack/[email protected] @tanstack/[email protected]
node repro.mjs     # every probe prints NO-OP; history never moves

npm i @tanstack/[email protected] @tanstack/[email protected]
node repro.mjs     # every probe prints "applied"

The last two lines of the script isolate it:

buildLocation  -> /operations?tab=lookup-data&list=sexes
after commit   -> /operations?tab=lookup-data        <- 1.170.36
after commit   -> /operations?tab=lookup-data&list=sexes  <- 1.170.35
Expected behavior

await router.navigate({ ... }) moves the router, as it does on 1.170.35 — history, latestLocation and state.location all reflect the new location. Equivalently, commitLocation applies a location that buildLocation built correctly.

Platform
  • OS: Linux (NixOS), x86-64
  • Node: 24.20.0
  • @tanstack/react-router: 1.170.36 (broken) vs 1.170.35 (working)
  • @tanstack/router-core: 1.171.30 (broken) vs 1.171.29 (working)
  • No bundler or framework involved — plain node repro.mjs
Additional context

Found because a Renovate patch bump turned a suite red that exists specifically to catch router behaviour changes. Holding at 1.170.35 for now.

主要言語
TypeScript
スター
15.3k
フォーク
1.9k
平均マージ
1日 5時間
マージ済み PR(30日)
46

環境構築

Codespaces で開く

このプロジェクトの開発コンテナを、あなたの GitHub アカウントでブラウザ上に起動します。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

TanStack/router のほかの issue

TanStack/router の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。