router.commitLocation is a no-op on 1.170.36 / router-core 1.171.30, so router.navigate() silently does nothing

Abierto
#8,479 2 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

  • #8560 de @00200200 — cerrado sin fusionar

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
65/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
javascript, react, typescript

Línea de trabajo

The issue is in router-core's commitLocation function. Start by examining the changes between versions 1.171.29 and 1.171.30 in the router-core package, focusing on commitLocation and navigate methods. The reproducer in the gist shows the exact failing calls. Run the provided repro.mjs to see the no-op behavior, then trace through the commitLocation logic to see why it doesn't update history. Look at the test suite to understand expected behavior.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Which project does this relate to?

Router

Describe the bug

On @tanstack/react-router 1.170.36 with @tanstack/router-core 1.171.30, router.navigate() does nothing at all on a router created programmatically. history.location, latestLocation and state.location all stay on the previous entry, the promise resolves undefined, and state.status is back to idle — so there is no pending navigation to await.

It is not path matching or location building. router.buildLocation({ to: ".", search: (p) => ({ ...p, list: "sexes" }) }) returns the correct /operations?tab=lookup-data&list=sexes on both versions. Passing that straight to router.commitLocation({ ...built, replace: true }) moves history on 1.170.35 and does not on 1.170.36. The regression is on the commit side.

Every navigation shape I tried is affected:

probe 1.170.35 1.170.36
to: "." + functional search updater applied no-op
to: "." + object search applied no-op
to: "/operations" + functional updater applied no-op
no to + functional updater applied no-op
to: "/horses/$id" + params (path change) applied no-op

Caveat, stated up front: the router in this reproducer is created programmatically and never rendered through RouterProvider. I have not established whether a mounted router is affected. I am reporting it because this shape is how a lot of test suites drive the router, and because the pair of patch releases changes it.

Complete minimal reproducer

https://gist.github.com/NickyTope/bcf0b4e05e194dc3b39406cc45c6783c

Steps to Reproduce the Bug
mkdir tsr-repro && cd tsr-repro
# take package.json and repro.mjs from the gist
npm i @tanstack/[email protected] @tanstack/[email protected]
node repro.mjs     # every probe prints NO-OP; history never moves

npm i @tanstack/[email protected] @tanstack/[email protected]
node repro.mjs     # every probe prints "applied"

The last two lines of the script isolate it:

buildLocation  -> /operations?tab=lookup-data&list=sexes
after commit   -> /operations?tab=lookup-data        <- 1.170.36
after commit   -> /operations?tab=lookup-data&list=sexes  <- 1.170.35
Expected behavior

await router.navigate({ ... }) moves the router, as it does on 1.170.35 — history, latestLocation and state.location all reflect the new location. Equivalently, commitLocation applies a location that buildLocation built correctly.

Platform
  • OS: Linux (NixOS), x86-64
  • Node: 24.20.0
  • @tanstack/react-router: 1.170.36 (broken) vs 1.170.35 (working)
  • @tanstack/router-core: 1.171.30 (broken) vs 1.171.29 (working)
  • No bundler or framework involved — plain node repro.mjs
Additional context

Found because a Renovate patch bump turned a suite red that exists specifically to catch router behaviour changes. Holding at 1.170.35 for now.

Lenguaje dominante
TypeScript
Estrellas
15.3k
Forks
1.9k
Merge medio
1 d 5 h
PR fusionados (30 d)
46

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de TanStack/router

Todos los issues de TanStack/router

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.