Ordered, limited live query over a string key commits `loading` first (and `orderBy().findOne()` since 0.11.1)
メンテナーはふだん 1 日以内に返信
関連するプルリクエストがすでにマージされています。
- #2159 @KyleAMathews による — マージ済み
評価
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 初心者へのやさしさ
- 18/100
- issue の種類
- バグ
- 明瞭さ
- おおむね明確
- 活発さ
- 停滞
- 技術スタック
- react, typescript
調査の方向性
The fallback is in OrderedSourceLoader.loadBoundary, and observe() decides sync versus async around isInitialFullSource and canRetryRepair in the same loader file. Run the repro test in packages/react-db/tests to see the loading-then-ready commit. Done when a string-ordered limit or findOne is ready in the first commit and the db test suite stays green, but PR #2159 already targets this and the fix needs maintainer-level understanding of the sync cut.
索引モデルが issue の本文から書いたものです。
説明
- I've validated the bug against the latest version of DB packages (
@tanstack/db0.14.0,@tanstack/react-db0.5.9)
Describe the bug
An ordered, limited live query whose first orderBy term is a string commits loading with no rows on its first render, even when the source already holds every row and answers synchronously. It becomes ready one task later. The same query ordered by a number is ready in the first commit, which is what #1896 set out to guarantee.
Since 0.11.1 this also hits orderBy(...).findOne(), because #1968 made findOne() imply limit(1) (compiler/order-by.ts). On 0.11.0, orderBy(stringField).findOne() was ready in the first commit; from 0.11.1 it commits loading first. Ordering by an ISO date string and taking the latest row is a common shape, so screens that branch on "no row yet" render their empty state for a frame.
Cause
With locale string collation, canExpressCursorOrder cannot express the boundary as a cursor, so OrderedSourceLoader.loadBoundary falls back to loadFullSource(). observe() treats every full-source request as an authoritative repair. Only a full-source request made before any request has settled (isInitialFullSource) shares the initial synchronous cut, so this fallback, which is still part of the initial load, settles asynchronously.
Logged observe() decisions for the same query:
number: ordered (sync) -> boundary (sync) => ready in first commit
string: ordered (sync) -> full-source (async) => loading, then ready
To Reproduce
packages/react-db/tests (jsdom, @testing-library/react):
import { renderHook } from '@testing-library/react'
import { useLayoutEffect } from 'react'
import { createCollection, localOnlyCollectionOptions } from '@tanstack/db'
import { expect, it } from 'vitest'
import { useLiveQuery } from '../src/useLiveQuery'
it(`publishes a synchronous ordered limit over a string key in the first layout commit`, () => {
const source = createCollection(
localOnlyCollectionOptions<{ id: string; at: string }, string>({
getKey: (row) => row.id,
initialData: [
{ id: `1`, at: `2026-10-01` },
{ id: `2`, at: `2026-10-02` },
],
}),
)
const commits: Array<string> = []
renderHook(() => {
const result = useLiveQuery((q) =>
q.from({ row: source }).orderBy(({ row }) => row.at, `desc`).findOne(),
)
useLayoutEffect(() => {
commits.push(`${result.status}:${result.data?.id}`)
})
})
expect(commits[0]).toBe(`ready:2`) // receives `loading:undefined`
})
The same happens with .limit(n) instead of .findOne(), with or without an index on the field (autoIndex: 'eager', BasicIndex), and over eager sync collections as well as local-only ones. Changing at to a number makes it pass.
Expected behavior
A full-source fallback made before the live query is ready is part of the initial load, so it should share the initial synchronous cut like the first full-source request of a requiresFullSource plan.
Possible fix
canRetryRepair (the loader's "live query is ready and no window operation is active" predicate) already distinguishes the initial load:
@@ -624,9 +624,13 @@ export class OrderedSourceLoader {
const orderingInvalidationGeneration = this.orderingInvalidationGeneration
const settlesAsync = result instanceof Promise
// A requiresFullSource plan's first full-source request is its initial
- // load, not a repair, so it shares the initial synchronous cut.
+ // load, not a repair, so it shares the initial synchronous cut. So does a
+ // full-source fallback made before the query is ready, such as a boundary
+ // that a locale string order cannot express as a cursor.
const isInitialFullSource =
- isFullSource && !this.hasSettledSourceRequest && !this.needsOrderingRepair
+ isFullSource &&
+ !this.needsOrderingRepair &&
+ (!this.hasSettledSourceRequest || !this.canRetryRepair())
const canSettleSynchronously =
!settlesAsync &&
windowOperationGeneration === undefined &&
With this change at 0.14.0, the repro passes, all 383 react-db tests pass, and 12,905 of 12,906 db tests pass. The one failure, local-storage-peer-oracle.test.ts > publishes through the default same-tab Storage object, fails identically without the change.
Additional context
Related: #1894 / #1896 (same symptom for numeric keys). We are running this as a local patch on 0.14.0 in a React Native app (Expo, new architecture).
- 主要言語
- TypeScript
- スター
- 3.9k
- フォーク
- 277
- 平均マージ
- 22時間 54分
- マージ済み PR(30日)
- 236
環境構築
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートあり
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
TanStack/db のほかの issue
-
難易度 4/5 3〜5日 初心者へのやさしさ 22/100
メンテナーはふだん 1 日以内に返信
-
難易度 5/5 1週間以上 初心者へのやさしさ 12/100
メンテナーはふだん 1 日以内に返信
-
難易度 5/5 1週間以上 初心者へのやさしさ 8/100
メンテナーはふだん 1 日以内に返信
-
難易度 4/5 3〜5日 初心者へのやさしさ 25/100
メンテナーはふだん 1 日以内に返信
-
難易度 5/5 1週間以上 初心者へのやさしさ 5/100
メンテナーはふだん 1 日以内に返信
似ている issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 76/100
paperclipai/paperclip#16785 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
code-yeongyu/senpi#3661 ·
メンテナーはふだん 1 日以内に返信
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
難易度 1/5 1時間未満 初心者へのやさしさ 78/100
lingdojo/kana-dojo#32731 · コメント 1 件 · リアクション 5 件 ·
メンテナーはふだん 1 日以内に返信
-
bug status: needs triage
難易度 2/5 1〜3時間 初心者へのやさしさ 76/100
mastra-ai/mastra#27538 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
Yeachan-Heo/oh-my-codex#3822 ·
メンテナーはふだん 1 日以内に返信