Approval resume validates null-widened history args, so approved tools fail with repairToolInput: false

オープン
  • 何か問題がありますか？
#2,073 コメント 0 件 リアクション 0 件 担当者 1 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

@tombeckenham がすでに取り組んでいます。

2026年11月6日 から。

評価

この issue はまだ評価されていません。

説明

waiting-on: maintainer

What happens

With the OpenAI adapter, an optional tool field comes back from the provider as null (strict-mode null widening). The live tool path undoes that before it validates. The approval resume path does not. It validates the arguments from the message history as they are.

So with repairToolInput: false, an approved tool fails its own input check on resume:

Input validation failed for tool bookFlight: #/date: Instance type "null" is invalid. Expected "string"., #: Property "date" does not match additional properties schema., #/date: False boolean schema.
Received arguments: {"destination":"Tokyo","date":null}

With the default repairToolInput it passes, because the repair step happens to coerce the null away.

The two events for one tool call also disagree:

  • TOOL_CALL_ARGS deltas, joined: {"destination":"Tokyo","date":null}
  • TOOL_CALL_END.input: {"destination":"Tokyo"}

An AG-UI client rebuilds the assistant tool call from the TOOL_CALL_ARGS deltas. That is the history it sends back on resume.

Expected

The resume path undoes null widening on the history arguments the same way the live path does, whatever repairToolInput is set to. Or TOOL_CALL_ARGS streams the same arguments that TOOL_CALL_END.input reports.

Repro

@tanstack/ai 1.2.0, @tanstack/ai-openai 1.1.1, Node 22, OPENAI_API_KEY set.

import { chat, toolDefinition, maxIterations } from "@tanstack/ai";
import { openaiText } from "@tanstack/ai-openai";

const bookFlight = toolDefinition({
  name: "bookFlight",
  description: "Book a flight",
  inputSchema: {
    type: "object",
    properties: { destination: { type: "string" }, date: { type: "string" } },
    required: ["destination"],
    additionalProperties: false,
  },
  needsApproval: true,
}).server(async () => ({ booked: true }));

const threadId = `repro-${Date.now()}`;
const user = { role: "user", content: "Book a flight to Tokyo. I have no date yet." };

// Run 1: pauses for approval.
const run1 = [];
for await (const chunk of chat({
  adapter: openaiText("gpt-4o-mini"),
  messages: [user],
  tools: [bookFlight],
  threadId,
  runId: "r1",
})) run1.push(chunk);

const { toolCallId } = run1.find((e) => e.type === "TOOL_CALL_START");
const streamedArgs = run1
  .filter((e) => e.type === "TOOL_CALL_ARGS" && e.toolCallId === toolCallId)
  .map((e) => e.delta)
  .join(""); // {"destination":"Tokyo","date":null}

// Run 2: approve, with the history a client rebuilt from the stream.
for await (const chunk of chat({
  adapter: openaiText("gpt-4o-mini"),
  messages: [
    user,
    {
      role: "assistant",
      content: "",
      toolCalls: [
        { id: toolCallId, type: "function", function: { name: "bookFlight", arguments: streamedArgs } },
      ],
    },
  ],
  tools: [bookFlight],
  threadId,
  runId: "r2",
  parentRunId: "r1",
  resume: [{ interruptId: `approval_${toolCallId}`, status: "resolved", payload: { approved: true } }],
  repairToolInput: false,
  agentLoopStrategy: maxIterations(3),
})) {
  if (chunk.type === "TOOL_CALL_RESULT") console.log(chunk.content); // input validation error
}

Results:

Run 2 history args repairToolInput Result
from TOOL_CALL_ARGS deltas false input validation error, tool does not run
from TOOL_CALL_ARGS deltas default tool runs
from TOOL_CALL_END.input false tool runs

Where it shows up

CopilotKit's built-in agent runs on chat() and sets repairToolInput: false, so tool argument errors go back to the model. Every approved tool with an optional field fails on resume there.

主要言語
TypeScript
スター
3.3k
フォーク
378
平均マージ
1日 3時間
マージ済み PR（30日）
253

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

TanStack/ai のほかの issue

TanStack/ai の issue をすべて見る

似ている issue

TypeScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。