Approval resume validates null-widened history args, so approved tools fail with repairToolInput: false

Ouverte
  • Quelque chose ne va pas ?
#2,073 0 commentaires 0 réactions 1 personne assignée Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

@tombeckenham y travaille déjà.

Depuis le 6/11/2026.

Évaluation

Cette issue n'a pas encore été évaluée.

Description

waiting-on: maintainer

What happens

With the OpenAI adapter, an optional tool field comes back from the provider as null (strict-mode null widening). The live tool path undoes that before it validates. The approval resume path does not. It validates the arguments from the message history as they are.

So with repairToolInput: false, an approved tool fails its own input check on resume:

Input validation failed for tool bookFlight: #/date: Instance type "null" is invalid. Expected "string"., #: Property "date" does not match additional properties schema., #/date: False boolean schema.
Received arguments: {"destination":"Tokyo","date":null}

With the default repairToolInput it passes, because the repair step happens to coerce the null away.

The two events for one tool call also disagree:

  • TOOL_CALL_ARGS deltas, joined: {"destination":"Tokyo","date":null}
  • TOOL_CALL_END.input: {"destination":"Tokyo"}

An AG-UI client rebuilds the assistant tool call from the TOOL_CALL_ARGS deltas. That is the history it sends back on resume.

Expected

The resume path undoes null widening on the history arguments the same way the live path does, whatever repairToolInput is set to. Or TOOL_CALL_ARGS streams the same arguments that TOOL_CALL_END.input reports.

Repro

@tanstack/ai 1.2.0, @tanstack/ai-openai 1.1.1, Node 22, OPENAI_API_KEY set.

import { chat, toolDefinition, maxIterations } from "@tanstack/ai";
import { openaiText } from "@tanstack/ai-openai";

const bookFlight = toolDefinition({
  name: "bookFlight",
  description: "Book a flight",
  inputSchema: {
    type: "object",
    properties: { destination: { type: "string" }, date: { type: "string" } },
    required: ["destination"],
    additionalProperties: false,
  },
  needsApproval: true,
}).server(async () => ({ booked: true }));

const threadId = `repro-${Date.now()}`;
const user = { role: "user", content: "Book a flight to Tokyo. I have no date yet." };

// Run 1: pauses for approval.
const run1 = [];
for await (const chunk of chat({
  adapter: openaiText("gpt-4o-mini"),
  messages: [user],
  tools: [bookFlight],
  threadId,
  runId: "r1",
})) run1.push(chunk);

const { toolCallId } = run1.find((e) => e.type === "TOOL_CALL_START");
const streamedArgs = run1
  .filter((e) => e.type === "TOOL_CALL_ARGS" && e.toolCallId === toolCallId)
  .map((e) => e.delta)
  .join(""); // {"destination":"Tokyo","date":null}

// Run 2: approve, with the history a client rebuilt from the stream.
for await (const chunk of chat({
  adapter: openaiText("gpt-4o-mini"),
  messages: [
    user,
    {
      role: "assistant",
      content: "",
      toolCalls: [
        { id: toolCallId, type: "function", function: { name: "bookFlight", arguments: streamedArgs } },
      ],
    },
  ],
  tools: [bookFlight],
  threadId,
  runId: "r2",
  parentRunId: "r1",
  resume: [{ interruptId: `approval_${toolCallId}`, status: "resolved", payload: { approved: true } }],
  repairToolInput: false,
  agentLoopStrategy: maxIterations(3),
})) {
  if (chunk.type === "TOOL_CALL_RESULT") console.log(chunk.content); // input validation error
}

Results:

Run 2 history args repairToolInput Result
from TOOL_CALL_ARGS deltas false input validation error, tool does not run
from TOOL_CALL_ARGS deltas default tool runs
from TOOL_CALL_END.input false tool runs

Where it shows up

CopilotKit's built-in agent runs on chat() and sets repairToolInput: false, so tool argument errors go back to the model. Every approved tool with an optional field fails on resume there.

Langage dominant
TypeScript
Étoiles
3.3k
Forks
386
Merge moyen
1 j 6 h
PR mergées (30 j)
221

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de TanStack/ai

Toutes les issues de TanStack/ai

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.